bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 01:03:35 +00:00
Code Issues Releases Wiki Activity

[PM-2270] Renamed Fido2Key.userName to Fido2Key.userDisplayName (#6005)

Browse Source 
* Renamed fido2key property username to userDisplayName

* Renamed username property on fido2key object to userdisplayname

* updated username to userDisplayName in fido2 export
This commit is contained in:
SmithThe4th
2023-09-01 09:30:33 -04:00
committed by GitHub
parent 419737d293
commit afcd952de5
17 changed files with 52 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/vault/popup/components/action-buttons.component.html
View File

@@ -120,9 +120,9 @@
appStopClick
appStopProp
appA11yTitle="{{ 'copyUsername' | i18n }}"
(click)="copy(cipher, cipher.fido2Key.userName, 'username', 'Username')"
[ngClass]="{ disabled: !cipher.fido2Key.userName }"
[attr.disabled]="!cipher.fido2Key.userName ? '' : null"
(click)="copy(cipher, cipher.fido2Key.userDisplayName, 'username', 'Username')"
[ngClass]="{ disabled: !cipher.fido2Key.userDisplayName }"
[attr.disabled]="!cipher.fido2Key.userDisplayName ? '' : null"
>
<i class="bwi bwi-lg bwi-user" aria-hidden="true"></i>
</button>

2
apps/browser/src/vault/popup/components/fido2/fido2.component.ts
View File

@@ -84,7 +84,7 @@ export class Fido2Component implements OnInit, OnDestroy {
cipher.name = message.credentialName;
cipher.type = CipherType.Fido2Key;
cipher.fido2Key = new Fido2KeyView();
cipher.fido2Key.userName = message.userName;
cipher.fido2Key.userDisplayName = message.userName;
this.ciphers = [cipher];
} else if (message.type === "PickCredentialRequest") {
this.ciphers = await Promise.all(

8
apps/browser/src/vault/popup/components/vault/add-edit.component.html
View File

@@ -478,12 +478,12 @@
<!-- Fido2Key -->
<div *ngIf="cipher.type === cipherType.Fido2Key">
<div class="box-content-row" appBoxRow>
<label for="fido2KeyUsername">{{ "username" | i18n }}</label>
<label for="fido2KeyUserDisplayName">{{ "username" | i18n }}</label>
<input
id="fido2KeyUsername"
id="fido2KeyUserDisplayName"
type="text"
name="Fido2Key.Username"
[(ngModel)]="cipher.fido2Key.userName"
name="Fido2Key.UserDisplayName"
[(ngModel)]="cipher.fido2Key.userDisplayName"
appInputVerbatim
[readonly]="!cipher.edit && editMode"
/>

2
apps/browser/src/vault/popup/components/vault/view.component.html
View File

@@ -428,7 +428,7 @@
<div *ngIf="cipher.type == cipherType.Fido2Key">
<div class="box-content-row">
<span class="row-label">{{ "username" | i18n }}</span>
{{ cipher.fido2Key.userName }}
{{ cipher.fido2Key.userDisplayName }}
</div>
<div class="box-content-row">
<span class="row-label">{{ "typePasskey" | i18n }}</span>

8
apps/desktop/src/vault/app/vault/add-edit.component.html
View File

@@ -461,12 +461,12 @@
<!-- Fido2Key -->
<div *ngIf="cipher.type === cipherType.Fido2Key">
<div class="box-content-row" appBoxRow>
<label for="fido2KeyUsername">{{ "username" | i18n }}</label>
<label for="fido2KeyUserDisplayName">{{ "username" | i18n }}</label>
<input
id="fido2KeyUsername"
id="fido2KeyUserDisplayName"
type="text"
name="Fido2Key.Username"
[(ngModel)]="cipher.fido2Key.userName"
name="Fido2Key.UserDisplayName"
[(ngModel)]="cipher.fido2Key.userDisplayName"
appInputVerbatim
[readonly]="!cipher.edit && editMode"
/>

2
apps/desktop/src/vault/app/vault/view.component.html
View File

@@ -399,7 +399,7 @@
<div class="box-content-row">
<div class="row-main">
<span class="row-label">{{ "username" | i18n }}</span>
{{ cipher.fido2Key.userName }}
{{ cipher.fido2Key.userDisplayName }}
</div>
</div>
<div class="box-content-row">

10
apps/web/src/app/vault/individual-vault/add-edit.component.html
View File

@@ -836,14 +836,14 @@
<ng-container *ngIf="cipher.type === cipherType.Fido2Key">
<div class="row">
<div class="col-6 form-group">
<label for="fido2keyUsername">{{ "username" | i18n }}</label>
<label for="fido2KeyUserDisplayName">{{ "username" | i18n }}</label>
<div class="input-group">
<input
id="fido2keyUsername"
id="fido2KeyUserDisplayName"
class="form-control"
type="text"
name="Fido2key.Username"
[(ngModel)]="cipher.fido2Key.userName"
name="Fido2key.UserDisplayName"
[(ngModel)]="cipher.fido2Key.userDisplayName"
appInputVerbatim
[disabled]="cipher.isDeleted || viewOnly"
[readonly]="!cipher.edit && editMode"
@@ -853,7 +853,7 @@
type="button"
class="btn btn-outline-secondary"
appA11yTitle="{{ 'copyUsername' | i18n }}"
(click)="copy(cipher.fido2Key.userName, 'username', 'Username')"
(click)="copy(cipher.fido2Key.userDisplayName, 'username', 'Username')"
>
<i class="bwi bwi-lg bwi-clone" aria-hidden="true"></i>
</button>