Merge branch 'main' into ps/extension-refresh

.github/renovate.json

@@ -69,14 +69,7 @@
       "reviewers": ["team:team-admin-console-dev"]
     },
     {
-      "matchPackageNames": [
-        "@types/duo_web_sdk",
-        "@types/node-ipc",
-        "duo_web_sdk",
-        "node-ipc",
-        "qrious",
-        "regedit"
-      ],
+      "matchPackageNames": ["@types/node-ipc", "node-ipc", "qrious", "regedit"],
       "description": "Auth owned dependencies",
       "commitMessagePrefix": "[deps] Auth:",
       "reviewers": ["team:team-auth-dev"]

.github/workflows/brew-bump-cli.yml

@@ -1,41 +0,0 @@
----
-name: Bump CLI Formula
-
-on:
-  push:
-    tags:
-      - cli-v**
-  workflow_dispatch:
-
-defaults:
-  run:
-    shell: bash
-
-jobs:
-  update-desktop-cask:
-    name: Update Bitwarden CLI Formula
-    runs-on: macos-13
-    steps:
-      - name: Login to Azure
-        uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0
-        with:
-          creds: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: Retrieve secrets
-        id: retrieve-secrets
-        uses: bitwarden/gh-actions/get-keyvault-secrets@main
-        with:
-          keyvault: "bitwarden-ci"
-          secrets: "brew-bump-workflow-pat"
-
-      - name: Update Homebrew formula
-        uses: dawidd6/action-homebrew-bump-formula@baf2b60c51fc1f8453c884b0c61052668a71bd1d # v3.11.0
-        with:
-          # Required, custom GitHub access token with the 'public_repo' and 'workflow' scopes
-          token: ${{ steps.retrieve-secrets.outputs.brew-bump-workflow-pat }}
-          org: bitwarden
-          tap: Homebrew/homebrew-core
-          formula: bitwarden-cli
-          tag: ${{ github.ref }}
-          revision: ${{ github.sha }}
-          force: true

.github/workflows/build-browser.yml

@@ -186,17 +186,10 @@ jobs:
       #     path: browser-source/apps/browser/dist/dist-opera-mv3.zip
       #     if-no-files-found: error
 
-      - name: Upload Chrome artifact
+      - name: Upload Chrome MV3 artifact
         uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
-          name: dist-chrome-${{ env._BUILD_NUMBER }}.zip
-          path: browser-source/apps/browser/dist/dist-chrome.zip
-          if-no-files-found: error
-
-      - name: Upload Chrome MV3 artifact (DO NOT USE FOR PROD)
-        uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
-        with:
-          name: DO-NOT-USE-FOR-PROD-dist-chrome-MV3-${{ env._BUILD_NUMBER }}.zip
+          name: dist-chrome-MV3-${{ env._BUILD_NUMBER }}.zip
           path: browser-source/apps/browser/dist/dist-chrome-mv3.zip
           if-no-files-found: error
 

.github/workflows/release-browser.yml

@@ -132,7 +132,7 @@ jobs:
           PACKAGE_VERSION: ${{ needs.setup.outputs.release-version }}
         run: |
           mv browser-source.zip browser-source-$PACKAGE_VERSION.zip
-          mv dist-chrome.zip dist-chrome-$PACKAGE_VERSION.zip
+          mv dist-chrome-mv3.zip dist-chrome-$PACKAGE_VERSION.zip
           mv dist-opera.zip dist-opera-$PACKAGE_VERSION.zip
           mv dist-firefox.zip dist-firefox-$PACKAGE_VERSION.zip
           mv dist-edge.zip dist-edge-$PACKAGE_VERSION.zip

.github/workflows/release-desktop-beta.yml

@@ -415,6 +415,9 @@ jobs:
           cache-dependency-path: '**/package-lock.json'
           node-version: ${{ env._NODE_VERSION }}
 
+      - name: Set up Node-gyp
+        run: python3 -m pip install setuptools
+
       - name: Print environment
         run: |
           node --version
@@ -546,6 +549,9 @@ jobs:
           cache-dependency-path: '**/package-lock.json'
           node-version: ${{ env._NODE_VERSION }}
 
+      - name: Set up Node-gyp
+        run: python3 -m pip install setuptools
+
       - name: Print environment
         run: |
           node --version
@@ -756,6 +762,9 @@ jobs:
           cache-dependency-path: '**/package-lock.json'
           node-version: ${{ env._NODE_VERSION }}
 
+      - name: Set up Node-gyp
+        run: python3 -m pip install setuptools
+
       - name: Print environment
         run: |
           node --version

.github/workflows/scan.yml

@@ -76,3 +76,4 @@ jobs:
             -Dsonar.projectKey=${{ github.repository_owner }}_${{ github.event.repository.name }}
             -Dsonar.test.inclusions=**/*.spec.ts
             -Dsonar.tests=.
+            -Dsonar.sources=.

.github/workflows/test.yml

@@ -1,5 +1,4 @@
----
-name: Run tests
+name: Testing
 
 on:
   workflow_dispatch:
@@ -8,29 +7,20 @@ on:
       - "main"
       - "rc"
       - "hotfix-rc-*"
-  pull_request_target:
+  pull_request:
     types: [opened, synchronize]
 
-defaults:
-  run:
-    shell: bash
-
 jobs:
-  check-run:
-    name: Check PR run
-    uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main
-
   test:
     name: Run tests
     runs-on: ubuntu-22.04
-    needs: check-run
     permissions:
       checks: write
       contents: read
       pull-requests: write
       
     steps:
-      - name: Checkout repo
+      - name: Check out repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       - name: Get Node Version
@@ -75,14 +65,26 @@ jobs:
           reporter: jest-junit
           fail-on-error: true
 
+      - name: Check for Codecov secret
+        id: check-codecov-secret
+        run: |
+          if [ "${{ secrets.CODECOV_TOKEN }}" != '' ]; then
+            echo "available=true" >> $GITHUB_OUTPUT;
+          else
+            echo "available=false" >> $GITHUB_OUTPUT;
+          fi
+
       - name: Upload to codecov.io
         uses: codecov/codecov-action@54bcd8715eee62d40e33596ef5e8f0f48dbbccab # v4.1.0
+        if: steps.check-codecov-secret.outputs.available == 'true'
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
   rust:
-    name: rust - ${{ matrix.os }}
+    name: Run Rust tests on ${{ matrix.os }}
     runs-on: ${{ matrix.os || 'ubuntu-latest' }}
+    permissions:
+      contents: read
 
     strategy:
       matrix:
@@ -92,7 +94,7 @@ jobs:
           - windows-latest
 
     steps:
-      - name: Rust version check
+      - name: Check Rust version
         run: rustup --version
 
       - name: Install gnome-keyring
@@ -101,7 +103,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y gnome-keyring dbus-x11
 
-      - name: Checkout repo
+      - name: Check out repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       - name: Build