bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 17:53:39 +00:00
Code Issues Releases Wiki Activity

Changed logic to validate if cipher has a collection on targetSelector method (#8422)

Browse Source 
Added tests to import.service.spec.ts that test if the collectionRelationship and folderRelationship properly adapts
This commit is contained in:
aj-rosado
2024-03-25 18:10:40 +00:00
committed by GitHub
parent 2ae6fbe275
commit b180463cc0
3 changed files with 97 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/importer/src/services/import.service.ts
View File

@@ -437,8 +437,10 @@ export class ImportService implements ImportServiceAbstraction {
const noCollectionRelationShips: [number, number][] = [];
importResult.ciphers.forEach((c, index) => {
if (!Array.isArray(c.collectionIds) || c.collectionIds.length == 0) {
c.collectionIds = [importTarget.id];
if (
!Array.isArray(importResult.collectionRelationships) ||
!importResult.collectionRelationships.some(([cipherPos]) => cipherPos === index)
) {
noCollectionRelationShips.push([index, 0]);
}
});