chore(feature flags): [PM-19034] Remove feature flags and old components for Set/Change Password

* Removed flag and components.

* More cleanup

* Removed ChangePasswordComponent.

* Removed old EmergencyAccessTakeover

* Removed service initialization.

* Fixed test failures.

* Fixed tests.

* Test changes.

* Updated comments

* Fixed tests.

* Fixed tests.

* Fixed merge conflict.

* Removed style and routing references.

* Better comments.

* Removed ResetPasswordComponent

apps/browser/src/auth/popup/set-password.component.html

@@ -1,160 +0,0 @@
-<form #form (ngSubmit)="submit()" [appApiAction]="formPromise">
-  <header>
-    <div class="left">
-      <button type="button" routerLink="/login">{{ "cancel" | i18n }}</button>
-    </div>
-    <h1 class="center">
-      <span class="title">{{ "setMasterPassword" | i18n }}</span>
-    </h1>
-    <div class="right">
-      <button type="submit" [disabled]="form.loading">
-        <span [hidden]="form.loading">{{ "submit" | i18n }}</span>
-        <i class="bwi bwi-spinner bwi-lg bwi-spin" [hidden]="!form.loading" aria-hidden="true"></i>
-      </button>
-    </div>
-  </header>
-  <main tabindex="-1">
-    <div class="full-loading-spinner" *ngIf="syncLoading">
-      <i class="bwi bwi-spinner bwi-spin bwi-3x" aria-hidden="true"></i>
-    </div>
-    <div *ngIf="!syncLoading">
-      <div class="box">
-        <p
-          class="tw-px-4"
-          *ngIf="
-            forceSetPasswordReason ==
-              ForceSetPasswordReason.TdeUserWithoutPasswordHasPasswordResetPermission;
-            else defaultCardDesc
-          "
-        >
-          {{ "orgPermissionsUpdatedMustSetPassword" | i18n }}
-        </p>
-
-        <ng-template #defaultCardDesc>
-          <p class="tw-px-4">{{ "orgRequiresYouToSetPassword" | i18n }}</p>
-        </ng-template>
-
-        <app-callout
-          type="warning"
-          title="{{ 'resetPasswordPolicyAutoEnroll' | i18n }}"
-          *ngIf="resetPasswordAutoEnroll"
-        >
-          {{ "resetPasswordAutoEnrollInviteWarning" | i18n }}
-        </app-callout>
-        <app-callout
-          type="info"
-          [enforcedPolicyOptions]="enforcedPolicyOptions"
-          *ngIf="enforcedPolicyOptions"
-        >
-        </app-callout>
-      </div>
-      <div class="box">
-        <div class="box-content">
-          <div class="box-content-row" appBoxRow>
-            <div class="box-content-row-flex">
-              <div class="row-main">
-                <label for="masterPassword">
-                  {{ "masterPass" | i18n }}
-                  <strong class="sub-label text-{{ color }}" *ngIf="text">
-                    {{ text }}
-                  </strong>
-                </label>
-                <input
-                  id="masterPassword"
-                  type="{{ showPassword ? 'text' : 'password' }}"
-                  name="MasterPassword"
-                  aria-describedby="masterPasswordHelp"
-                  class="monospaced"
-                  [(ngModel)]="masterPassword"
-                  required
-                  appInputVerbatim
-                />
-              </div>
-              <div class="action-buttons">
-                <button
-                  type="button"
-                  class="row-btn"
-                  appStopClick
-                  appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-                  (click)="togglePassword(false)"
-                  [attr.aria-pressed]="showPassword"
-                >
-                  <i
-                    class="bwi bwi-lg"
-                    aria-hidden="true"
-                    [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-                  ></i>
-                </button>
-              </div>
-            </div>
-
-            <app-password-strength
-              [password]="masterPassword"
-              [email]="email"
-              (passwordStrengthResult)="getStrengthResult($event)"
-              (passwordScoreColor)="getPasswordScoreText($event)"
-            >
-            </app-password-strength>
-          </div>
-        </div>
-        <div id="masterPasswordHelp" class="box-footer">
-          {{ "masterPassDesc" | i18n }}
-        </div>
-      </div>
-      <div class="box">
-        <div class="box-content">
-          <div class="box-content-row" appBoxRow>
-            <div class="box-content-row-flex">
-              <div class="row-main">
-                <label for="masterPasswordRetype">{{ "reTypeMasterPass" | i18n }}</label>
-                <input
-                  id="masterPasswordRetype"
-                  type="password"
-                  name="MasterPasswordRetype"
-                  class="monospaced"
-                  [(ngModel)]="masterPasswordRetype"
-                  required
-                  appInputVerbatim
-                  autocomplete="new-password"
-                />
-              </div>
-              <div class="action-buttons">
-                <button
-                  type="button"
-                  class="row-btn"
-                  appStopClick
-                  appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-                  (click)="togglePassword(true)"
-                  [attr.aria-pressed]="showPassword"
-                >
-                  <i
-                    class="bwi bwi-lg"
-                    aria-hidden="true"
-                    [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-                  ></i>
-                </button>
-              </div>
-            </div>
-          </div>
-        </div>
-      </div>
-      <div class="box last">
-        <div class="box-content">
-          <div class="box-content-row" appBoxRow>
-            <label for="hint">{{ "masterPassHint" | i18n }}</label>
-            <input
-              id="hint"
-              type="text"
-              name="Hint"
-              aria-describedby="hintHelp"
-              [(ngModel)]="hint"
-            />
-          </div>
-        </div>
-        <div id="hintHelp" class="box-footer">
-          {{ "masterPassHintDesc" | i18n }}
-        </div>
-      </div>
-    </div>
-  </main>
-</form>

apps/browser/src/auth/popup/set-password.component.ts

@@ -1,10 +0,0 @@
-import { Component } from "@angular/core";
-
-import { SetPasswordComponent as BaseSetPasswordComponent } from "@bitwarden/angular/auth/components/set-password.component";
-
-@Component({
-  selector: "app-set-password",
-  templateUrl: "set-password.component.html",
-  standalone: false,
-})
-export class SetPasswordComponent extends BaseSetPasswordComponent {}

apps/browser/src/auth/popup/update-temp-password.component.html

@@ -1,142 +0,0 @@
-<form #form (ngSubmit)="submit()" [appApiAction]="formPromise">
-  <header>
-    <div class="left">
-      <button type="button" (click)="logOut()">{{ "logOut" | i18n }}</button>
-    </div>
-    <h1 class="center">
-      <span class="title">{{ "updateMasterPassword" | i18n }}</span>
-    </h1>
-    <div class="right">
-      <button type="submit" [disabled]="form.loading">
-        <span [hidden]="form.loading">{{ "submit" | i18n }}</span>
-        <i class="bwi bwi-spinner bwi-lg bwi-spin" [hidden]="!form.loading" aria-hidden="true"></i>
-      </button>
-    </div>
-  </header>
-  <main tabindex="-1">
-    <app-callout type="warning" title="{{ 'updateMasterPassword' | i18n }}">
-      {{ masterPasswordWarningText }}
-    </app-callout>
-    <app-callout
-      type="info"
-      [enforcedPolicyOptions]="enforcedPolicyOptions"
-      *ngIf="enforcedPolicyOptions"
-    >
-    </app-callout>
-    <div class="box" *ngIf="requireCurrentPassword">
-      <div class="box-content">
-        <div class="box-content-row" appBoxRow>
-          <div class="box-content-row-flex">
-            <div class="row-main">
-              <label for="currentMasterPassword">
-                {{ "currentMasterPass" | i18n }}
-              </label>
-              <input
-                id="currentMasterPassword"
-                type="password"
-                name="CurrentMasterPassword"
-                class="monospaced"
-                [(ngModel)]="verification.secret"
-                required
-                appInputVerbatim
-              />
-            </div>
-          </div>
-        </div>
-      </div>
-    </div>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row" appBoxRow>
-          <div class="box-content-row-flex">
-            <div class="row-main">
-              <label for="masterPassword">
-                {{ "newMasterPass" | i18n }}
-                <strong class="sub-label text-{{ color }}" *ngIf="text">
-                  {{ text }}
-                </strong>
-              </label>
-              <input
-                id="masterPassword"
-                type="{{ showPassword ? 'text' : 'password' }}"
-                name="MasterPassword"
-                class="monospaced"
-                [(ngModel)]="masterPassword"
-                required
-                appInputVerbatim
-              />
-            </div>
-            <div class="action-buttons">
-              <button
-                type="button"
-                class="row-btn"
-                appStopClick
-                appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-                (click)="togglePassword(false)"
-                [attr.aria-pressed]="showPassword"
-              >
-                <i
-                  class="bwi bwi-lg"
-                  aria-hidden="true"
-                  [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-                ></i>
-              </button>
-            </div>
-          </div>
-          <app-password-strength
-            [password]="masterPassword"
-            [email]="email"
-            (passwordStrengthResult)="getStrengthResult($event)"
-            (passwordScoreColor)="getPasswordScoreText($event)"
-          >
-          </app-password-strength>
-        </div>
-      </div>
-    </div>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row box-content-row-flex" appBoxRow>
-          <div class="row-main">
-            <label for="masterPasswordRetype">{{ "confirmNewMasterPass" | i18n }}</label>
-            <input
-              id="masterPasswordRetype"
-              type="{{ showPassword ? 'text' : 'password' }}"
-              name="MasterPasswordRetype"
-              class="monospaced"
-              [(ngModel)]="masterPasswordRetype"
-              required
-              appInputVerbatim
-            />
-          </div>
-          <div class="action-buttons">
-            <button
-              type="button"
-              class="row-btn"
-              appStopClick
-              appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-              (click)="togglePassword(true)"
-              [attr.aria-pressed]="showPassword"
-            >
-              <i
-                class="bwi bwi-lg"
-                aria-hidden="true"
-                [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-              ></i>
-            </button>
-          </div>
-        </div>
-      </div>
-    </div>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row" appBoxRow>
-          <label for="hint">{{ "masterPassHint" | i18n }}</label>
-          <input id="hint" type="text" name="Hint" aria-describedby="hintHelp" [(ngModel)]="hint" />
-        </div>
-      </div>
-      <div id="hintHelp" class="box-footer">
-        {{ "masterPassHintDesc" | i18n }}
-      </div>
-    </div>
-  </main>
-</form>

apps/browser/src/auth/popup/update-temp-password.component.ts

@@ -1,30 +0,0 @@
-import { Component } from "@angular/core";
-import { firstValueFrom } from "rxjs";
-
-import { UpdateTempPasswordComponent as BaseUpdateTempPasswordComponent } from "@bitwarden/angular/auth/components/update-temp-password.component";
-
-import { postLogoutMessageListener$ } from "./utils/post-logout-message-listener";
-
-@Component({
-  selector: "app-update-temp-password",
-  templateUrl: "update-temp-password.component.html",
-  standalone: false,
-})
-export class UpdateTempPasswordComponent extends BaseUpdateTempPasswordComponent {
-  onSuccessfulChangePassword: () => Promise<void> = this.doOnSuccessfulChangePassword.bind(this);
-
-  private async doOnSuccessfulChangePassword() {
-    // start listening for "switchAccountFinish" or "doneLoggingOut"
-    const messagePromise = firstValueFrom(postLogoutMessageListener$);
-    this.messagingService.send("logout");
-    // wait for messages
-    const command = await messagePromise;
-
-    // doneLoggingOut already has a message handler that will navigate us
-    if (command === "switchAccountFinish") {
-      // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
-      // eslint-disable-next-line @typescript-eslint/no-floating-promises
-      this.router.navigate(["/"]);
-    }
-  }
-}

apps/browser/src/popup/app-routing.module.ts

@@ -32,7 +32,6 @@ import {
   RegistrationStartSecondaryComponent,
   RegistrationStartSecondaryComponentData,
   RegistrationUserAddIcon,
-  SetPasswordJitComponent,
   SsoComponent,
   TwoFactorTimeoutIcon,
   TwoFactorAuthComponent,
@@ -43,15 +42,13 @@ import {
   VaultIcon,
 } from "@bitwarden/auth/angular";
 import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
-import { AnonLayoutWrapperComponent, AnonLayoutWrapperData, Icons } from "@bitwarden/components";
+import { AnonLayoutWrapperData, Icons } from "@bitwarden/components";
 import { LockComponent } from "@bitwarden/key-management-ui";
 
 import { AccountSwitcherComponent } from "../auth/popup/account-switching/account-switcher.component";
 import { fido2AuthGuard } from "../auth/popup/guards/fido2-auth.guard";
-import { SetPasswordComponent } from "../auth/popup/set-password.component";
 import { AccountSecurityComponent } from "../auth/popup/settings/account-security.component";
 import { ExtensionDeviceManagementComponent } from "../auth/popup/settings/extension-device-management.component";
-import { UpdateTempPasswordComponent } from "../auth/popup/update-temp-password.component";
 import { Fido2Component } from "../autofill/popup/fido2/fido2.component";
 import { AutofillComponent } from "../autofill/popup/settings/autofill.component";
 import { BlockedDomainsComponent } from "../autofill/popup/settings/blocked-domains.component";
@@ -180,11 +177,6 @@ const routes: Routes = [
       elevation: 1,
     } satisfies RouteDataProperties & ExtensionAnonLayoutWrapperData,
   },
-  {
-    path: "set-password",
-    component: SetPasswordComponent,
-    data: { elevation: 1 } satisfies RouteDataProperties,
-  },
   {
     path: "remove-password",
     component: RemovePasswordComponent,
@@ -337,20 +329,6 @@ const routes: Routes = [
     canActivate: [authGuard],
     data: { elevation: 1 } satisfies RouteDataProperties,
   },
-  {
-    path: "update-temp-password",
-    component: UpdateTempPasswordComponent,
-    canActivate: [
-      canAccessFeature(
-        FeatureFlag.PM16117_ChangeExistingPasswordRefactor,
-        false,
-        `/change-password`,
-        false,
-      ),
-      authGuard,
-    ],
-    data: { elevation: 1 } satisfies RouteDataProperties,
-  },
   {
     path: "",
     component: ExtensionAnonLayoutWrapperComponent,
@@ -398,7 +376,7 @@ const routes: Routes = [
       },
       {
         path: "set-initial-password",
-        canActivate: [canAccessFeature(FeatureFlag.PM16117_SetInitialPasswordRefactor), authGuard],
+        canActivate: [authGuard],
         component: SetInitialPasswordComponent,
         data: {
           elevation: 1,
@@ -586,29 +564,7 @@ const routes: Routes = [
             component: ChangePasswordComponent,
           },
         ],
-        canActivate: [
-          canAccessFeature(FeatureFlag.PM16117_ChangeExistingPasswordRefactor),
-          authGuard,
-        ],
-      },
-    ],
-  },
-  {
-    path: "",
-    component: AnonLayoutWrapperComponent,
-    children: [
-      {
-        path: "set-password-jit",
-        component: SetPasswordJitComponent,
-        data: {
-          pageTitle: {
-            key: "joinOrganization",
-          },
-          pageSubtitle: {
-            key: "finishJoiningThisOrganizationBySettingAMasterPassword",
-          },
-          elevation: 1,
-        } satisfies RouteDataProperties & AnonLayoutWrapperData,
+        canActivate: [authGuard],
       },
     ],
   },

apps/browser/src/popup/app.module.ts

@@ -26,10 +26,8 @@ import {
 
 import { AccountComponent } from "../auth/popup/account-switching/account.component";
 import { CurrentAccountComponent } from "../auth/popup/account-switching/current-account.component";
-import { SetPasswordComponent } from "../auth/popup/set-password.component";
 import { AccountSecurityComponent } from "../auth/popup/settings/account-security.component";
 import { VaultTimeoutInputComponent } from "../auth/popup/settings/vault-timeout-input.component";
-import { UpdateTempPasswordComponent } from "../auth/popup/update-temp-password.component";
 import { AutofillComponent } from "../autofill/popup/settings/autofill.component";
 import { NotificationsSettingsComponent } from "../autofill/popup/settings/notifications.component";
 import { RemovePasswordComponent } from "../key-management/key-connector/remove-password.component";
@@ -96,9 +94,7 @@ import "../platform/popup/locales";
     AppComponent,
     ColorPasswordPipe,
     ColorPasswordCountPipe,
-    SetPasswordComponent,
     TabsV2Component,
-    UpdateTempPasswordComponent,
     UserVerificationComponent,
     VaultTimeoutInputComponent,
     RemovePasswordComponent,