From b54c40ff009a49a1b50bfb4077ce7b62db83ae6e Mon Sep 17 00:00:00 2001 From: Nick Krantz <125900171+nick-livefront@users.noreply.github.com> Date: Mon, 7 Jul 2025 09:26:34 -0500 Subject: [PATCH] Refactor `PendingSecurityTasks` to `RefreshSecurityTasks` (#15021) - Allows for more general use case of security task notifications --- libs/common/src/enums/notification-type.enum.ts | 2 +- .../src/vault/tasks/services/default-task.service.spec.ts | 4 ++-- libs/common/src/vault/tasks/services/default-task.service.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/common/src/enums/notification-type.enum.ts b/libs/common/src/enums/notification-type.enum.ts index 6d731253ce3..d362ffc841a 100644 --- a/libs/common/src/enums/notification-type.enum.ts +++ b/libs/common/src/enums/notification-type.enum.ts @@ -29,5 +29,5 @@ export enum NotificationType { Notification = 20, NotificationStatus = 21, - PendingSecurityTasks = 22, + RefreshSecurityTasks = 22, } diff --git a/libs/common/src/vault/tasks/services/default-task.service.spec.ts b/libs/common/src/vault/tasks/services/default-task.service.spec.ts index d90889cf113..a1f9872266e 100644 --- a/libs/common/src/vault/tasks/services/default-task.service.spec.ts +++ b/libs/common/src/vault/tasks/services/default-task.service.spec.ts @@ -365,7 +365,7 @@ describe("Default task service", () => { const subscription = service.listenForTaskNotifications(); const notification = { - type: NotificationType.PendingSecurityTasks, + type: NotificationType.RefreshSecurityTasks, } as NotificationResponse; mockNotifications$.next([notification, userId]); @@ -390,7 +390,7 @@ describe("Default task service", () => { const subscription = service.listenForTaskNotifications(); const notification = { - type: NotificationType.PendingSecurityTasks, + type: NotificationType.RefreshSecurityTasks, } as NotificationResponse; mockNotifications$.next([notification, "other-user-id" as UserId]); diff --git a/libs/common/src/vault/tasks/services/default-task.service.ts b/libs/common/src/vault/tasks/services/default-task.service.ts index 5858ba832d5..35a7561d63d 100644 --- a/libs/common/src/vault/tasks/services/default-task.service.ts +++ b/libs/common/src/vault/tasks/services/default-task.service.ts @@ -152,7 +152,7 @@ export class DefaultTaskService implements TaskService { return this.notificationService.notifications$.pipe( filter( ([notification, userId]) => - notification.type === NotificationType.PendingSecurityTasks && + notification.type === NotificationType.RefreshSecurityTasks && filterByUserIds.includes(userId), ), map(([, userId]) => userId),