From b5d77f53f42fddba8ec84139e269b2236ca3c15f Mon Sep 17 00:00:00 2001
From: Brad Deibert <bdeibert@bitwarden.com>
Date: Tue, 20 Jan 2026 09:35:10 -0800
Subject: [PATCH] consolidate @if statements, use @else where appropriate

---
 .../app/dirt/reports/pages/breach-report.component.html   | 8 ++------
 .../reports/pages/exposed-passwords-report.component.html | 3 +--
 .../pages/inactive-two-factor-report.component.html       | 6 ++----
 .../reports/pages/reused-passwords-report.component.html  | 6 ++----
 .../pages/unsecured-websites-report.component.html        | 6 ++----
 .../reports/pages/weak-passwords-report.component.html    | 6 ++----
 6 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/apps/web/src/app/dirt/reports/pages/breach-report.component.html b/apps/web/src/app/dirt/reports/pages/breach-report.component.html
index 3a302b759b3..0915902143e 100644
--- a/apps/web/src/app/dirt/reports/pages/breach-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/breach-report.component.html
@@ -16,19 +16,15 @@
     <div class="tw-mt-4">
       @if (error) {
         <p>{{ "reportError" | i18n }}...</p>
-      }
-      @if (!error) {
+      } @else {
         @if (!breachedAccounts.length) {
           <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
             {{ "breachUsernameNotFound" | i18n: checkedUsername }}
           </bit-callout>
-        }
-        @if (breachedAccounts.length) {
+        } @else {
           <bit-callout type="danger" title="{{ 'breachFound' | i18n }}">
             {{ "breachUsernameFound" | i18n: checkedUsername : breachedAccounts.length }}
           </bit-callout>
-        }
-        @if (breachedAccounts.length) {
           <ul
             class="tw-list-none tw-flex-col tw-divide-x-0 tw-divide-y tw-divide-solid tw-divide-secondary-300 tw-rounded tw-border tw-border-solid tw-border-secondary-300 tw-p-0"
           >
diff --git a/apps/web/src/app/dirt/reports/pages/exposed-passwords-report.component.html b/apps/web/src/app/dirt/reports/pages/exposed-passwords-report.component.html
index b5b964a11b7..88ef4959530 100644
--- a/apps/web/src/app/dirt/reports/pages/exposed-passwords-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/exposed-passwords-report.component.html
@@ -11,8 +11,7 @@
         <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
           {{ "noExposedPasswords" | i18n }}
         </bit-callout>
-      }
-      @if (ciphers.length) {
+      } @else {
         <bit-callout
           type="danger"
           title="{{ 'exposedPasswordsFound' | i18n }}"
diff --git a/apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.html b/apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.html
index 592d6030f66..1fcc2cd3246 100644
--- a/apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.html
@@ -11,15 +11,13 @@
       ></i>
       <span class="tw-sr-only">{{ "loading" | i18n }}</span>
     </div>
-  }
-  @if (hasLoaded) {
+  } @else {
     <div class="tw-mt-4">
       @if (!ciphers.length) {
         <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
           {{ "noInactive2fa" | i18n }}
         </bit-callout>
-      }
-      @if (ciphers.length) {
+      } @else {
         <bit-callout type="danger" title="{{ 'inactive2faFound' | i18n }}">
           {{ "inactive2faFoundReportDesc" | i18n: (ciphers.length | number) : vaultMsg }}
         </bit-callout>
diff --git a/apps/web/src/app/dirt/reports/pages/reused-passwords-report.component.html b/apps/web/src/app/dirt/reports/pages/reused-passwords-report.component.html
index af6b012d0c9..eb0d1180c1e 100644
--- a/apps/web/src/app/dirt/reports/pages/reused-passwords-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/reused-passwords-report.component.html
@@ -11,15 +11,13 @@
       ></i>
       <span class="tw-sr-only">{{ "loading" | i18n }}</span>
     </div>
-  }
-  @if (hasLoaded) {
+  } @else {
     <div class="tw-mt-4">
       @if (!ciphers.length) {
         <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
           {{ "noReusedPasswords" | i18n }}
         </bit-callout>
-      }
-      @if (ciphers.length) {
+      } @else {
         <bit-callout type="danger" title="{{ 'reusedPasswordsFound' | i18n }}">
           {{ "reusedPasswordsFoundReportDesc" | i18n: (ciphers.length | number) : vaultMsg }}
         </bit-callout>
diff --git a/apps/web/src/app/dirt/reports/pages/unsecured-websites-report.component.html b/apps/web/src/app/dirt/reports/pages/unsecured-websites-report.component.html
index 1b2652d6258..336a0558bbc 100644
--- a/apps/web/src/app/dirt/reports/pages/unsecured-websites-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/unsecured-websites-report.component.html
@@ -11,15 +11,13 @@
       ></i>
       <span class="tw-sr-only">{{ "loading" | i18n }}</span>
     </div>
-  }
-  @if (hasLoaded) {
+  } @else {
     <div class="tw-mt-4">
       @if (!ciphers.length) {
         <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
           {{ "noUnsecuredWebsites" | i18n }}
         </bit-callout>
-      }
-      @if (ciphers.length) {
+      } @else {
         <bit-callout type="danger" title="{{ 'unsecuredWebsitesFound' | i18n }}">
           {{ "unsecuredWebsitesFoundReportDesc" | i18n: (ciphers.length | number) : vaultMsg }}
         </bit-callout>
diff --git a/apps/web/src/app/dirt/reports/pages/weak-passwords-report.component.html b/apps/web/src/app/dirt/reports/pages/weak-passwords-report.component.html
index b16a9bc2bdc..51474f827d2 100644
--- a/apps/web/src/app/dirt/reports/pages/weak-passwords-report.component.html
+++ b/apps/web/src/app/dirt/reports/pages/weak-passwords-report.component.html
@@ -11,15 +11,13 @@
       ></i>
       <span class="tw-sr-only">{{ "loading" | i18n }}</span>
     </div>
-  }
-  @if (hasLoaded) {
+  } @else {
     <div class="tw-mt-4">
       @if (!ciphers.length) {
         <bit-callout type="success" title="{{ 'goodNews' | i18n }}">
           {{ "noWeakPasswords" | i18n }}
         </bit-callout>
-      }
-      @if (ciphers.length) {
+      } @else {
         <bit-callout type="danger" title="{{ 'weakPasswordsFound' | i18n }}">
           {{ "weakPasswordsFoundReportDesc" | i18n: (ciphers.length | number) : vaultMsg }}
         </bit-callout>