bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

remove analytics settings

Browse Source
This commit is contained in:
Kyle Spearrin
2019-01-15 11:08:25 -05:00
parent 5d8f43ab9a
commit b6705bc338
4 changed files with 1 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
jslib

Submodule jslib updated: 2e9ce15715...f4c4f28026

6
src/_locales/en/messages.json
View File

@@ -280,9 +280,6 @@
"other": { "other": {
"message": "Other" "message": "Other"
}, },
"disableGa": {
"message": "Disable Analytics"
},
"rateExtension": { "rateExtension": {
"message": "Rate the Extension" "message": "Rate the Extension"
}, },
@@ -496,9 +493,6 @@
"message": "No Folder", "message": "No Folder",
"description": "This is the folder for uncategorized items" "description": "This is the folder for uncategorized items"
}, },
"gaDesc": {
"message": "We use analytics to better learn how the extension is being used so that we can make it better. All data collection is completely anonymous."
},
"disableAddLoginNotification": { "disableAddLoginNotification": {
"message": "Disable Add Login Notification" "message": "Disable Add Login Notification"
}, },

9
src/popup/settings/options.component.html
View File

@@ -64,15 +64,6 @@
</div> </div>
<div class="box-footer">{{'dontShowIdentitiesCurrentTabDesc' | i18n}}</div> <div class="box-footer">{{'dontShowIdentitiesCurrentTabDesc' | i18n}}</div>
</div> </div>
<div class="box">
<div class="box-content">
<div class="box-content-row box-content-row-checkbox" appBoxRow>
<label for="ga">{{'disableGa' | i18n}}</label>
<input id="ga" type="checkbox" (change)="saveGa()" [(ngModel)]="disableGa">
</div>
</div>
<div class="box-footer">{{'gaDesc' | i18n}}</div>
</div>
<div class="box"> <div class="box">
<div class="box-content"> <div class="box-content">
<div class="box-content-row box-content-row-checkbox" appBoxRow> <div class="box-content-row box-content-row-checkbox" appBoxRow>

15
src/popup/settings/options.component.ts
View File

@@ -30,7 +30,6 @@ export class OptionsComponent implements OnInit {
dontShowCards = false; dontShowCards = false;
dontShowIdentities = false; dontShowIdentities = false;
showDisableContextMenu = true; showDisableContextMenu = true;
disableGa = false;
theme: string; theme: string;
themeOptions: any[]; themeOptions: any[];
defaultUriMatch = UriMatchType.Domain; defaultUriMatch = UriMatchType.Domain;
@@ -61,10 +60,6 @@ export class OptionsComponent implements OnInit {
this.enableAutoFillOnPageLoad = await this.storageService.get<boolean>( this.enableAutoFillOnPageLoad = await this.storageService.get<boolean>(
ConstantsService.enableAutoFillOnPageLoadKey); ConstantsService.enableAutoFillOnPageLoadKey);
const disableGa = await this.storageService.get<boolean>(ConstantsService.disableGaKey);
const disableGaByDefault = this.platformUtilsService.isFirefox();
this.disableGa = disableGa || (disableGa == null && disableGaByDefault);
this.disableAddLoginNotification = await this.storageService.get<boolean>( this.disableAddLoginNotification = await this.storageService.get<boolean>(
ConstantsService.disableAddLoginNotificationKey); ConstantsService.disableAddLoginNotificationKey);
@@ -87,16 +82,6 @@ export class OptionsComponent implements OnInit {
this.defaultUriMatch = defaultUriMatch == null ? UriMatchType.Domain : defaultUriMatch; this.defaultUriMatch = defaultUriMatch == null ? UriMatchType.Domain : defaultUriMatch;
} }
async saveGa() {
if (this.disableGa) {
this.callAnalytics('Analytics', !this.disableGa);
}
await this.storageService.save(ConstantsService.disableGaKey, this.disableGa);
if (!this.disableGa) {
this.callAnalytics('Analytics', !this.disableGa);
}
}
async updateAddLoginNotification() { async updateAddLoginNotification() {
await this.storageService.save(ConstantsService.disableAddLoginNotificationKey, await this.storageService.save(ConstantsService.disableAddLoginNotificationKey,
this.disableAddLoginNotification); this.disableAddLoginNotification);