diff --git a/apps/browser/src/key-management/lock/services/extension-lock-component.service.spec.ts b/apps/browser/src/key-management/lock/services/extension-lock-component.service.spec.ts index 272201c6ede..2e4ce8e1d47 100644 --- a/apps/browser/src/key-management/lock/services/extension-lock-component.service.spec.ts +++ b/apps/browser/src/key-management/lock/services/extension-lock-component.service.spec.ts @@ -9,8 +9,12 @@ import { import { VaultTimeoutSettingsService } from "@bitwarden/common/abstractions/vault-timeout/vault-timeout-settings.service"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { UserId } from "@bitwarden/common/types/guid"; -import { KeyService, BiometricsService } from "@bitwarden/key-management"; -import { BiometricsDisableReason, UnlockOptions } from "@bitwarden/key-management/angular"; +import { + KeyService, + BiometricsService, + BiometricsDisableReason, + UnlockOptions, +} from "@bitwarden/key-management"; import { BrowserRouterService } from "../../../platform/popup/services/browser-router.service"; diff --git a/apps/browser/src/key-management/lock/services/extension-lock-component.service.ts b/apps/browser/src/key-management/lock/services/extension-lock-component.service.ts index 07fb2ec6b87..5c29f8ed44e 100644 --- a/apps/browser/src/key-management/lock/services/extension-lock-component.service.ts +++ b/apps/browser/src/key-management/lock/services/extension-lock-component.service.ts @@ -11,12 +11,13 @@ import { VaultTimeoutSettingsService } from "@bitwarden/common/abstractions/vaul import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { KeySuffixOptions } from "@bitwarden/common/platform/enums"; import { UserId } from "@bitwarden/common/types/guid"; -import { KeyService, BiometricsService } from "@bitwarden/key-management"; import { + KeyService, + BiometricsService, LockComponentService, BiometricsDisableReason, UnlockOptions, -} from "@bitwarden/key-management/angular"; +} from "@bitwarden/key-management"; import { BiometricErrors, BiometricErrorTypes } from "../../../models/biometricErrors"; import { BrowserRouterService } from "../../../platform/popup/services/browser-router.service"; diff --git a/apps/browser/src/popup/app-routing.module.ts b/apps/browser/src/popup/app-routing.module.ts index 597a226e493..9cc8cee920f 100644 --- a/apps/browser/src/popup/app-routing.module.ts +++ b/apps/browser/src/popup/app-routing.module.ts @@ -42,7 +42,7 @@ import { TwoFactorTimeoutIcon, } from "@bitwarden/auth/angular"; import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum"; -import { LockV2Component } from "@bitwarden/key-management/angular"; +import { LockV2Component } from "@bitwarden/key-management"; import { twofactorRefactorSwap } from "../../../../libs/angular/src/utils/two-factor-component-refactor-route-swap"; import { fido2AuthGuard } from "../auth/guards/fido2-auth.guard"; diff --git a/apps/browser/src/popup/services/services.module.ts b/apps/browser/src/popup/services/services.module.ts index 85fa0d43076..861728e2f74 100644 --- a/apps/browser/src/popup/services/services.module.ts +++ b/apps/browser/src/popup/services/services.module.ts @@ -113,8 +113,8 @@ import { KeyService, BiometricStateService, BiometricsService, + LockComponentService, } from "@bitwarden/key-management"; -import { LockComponentService } from "@bitwarden/key-management/angular"; import { PasswordRepromptService } from "@bitwarden/vault"; import { ForegroundLockService } from "../../auth/popup/accounts/foreground-lock.service"; diff --git a/apps/browser/tsconfig.json b/apps/browser/tsconfig.json index c1ef1443acc..6b53186e076 100644 --- a/apps/browser/tsconfig.json +++ b/apps/browser/tsconfig.json @@ -34,7 +34,6 @@ "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"], "@bitwarden/tools-card": ["../../libs/tools/card/src"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/vault": ["../../libs/vault/src"] }, "plugins": [ diff --git a/apps/cli/tsconfig.json b/apps/cli/tsconfig.json index 0668ecacdb4..3853cd93126 100644 --- a/apps/cli/tsconfig.json +++ b/apps/cli/tsconfig.json @@ -26,7 +26,6 @@ "../../libs/tools/export/vault-export/vault-export-core/src" ], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/node/*": ["../../libs/node/src/*"] }, "plugins": [ diff --git a/apps/desktop/src/app/app-routing.module.ts b/apps/desktop/src/app/app-routing.module.ts index 463d073850c..c249b1bb0f6 100644 --- a/apps/desktop/src/app/app-routing.module.ts +++ b/apps/desktop/src/app/app-routing.module.ts @@ -39,7 +39,7 @@ import { TwoFactorTimeoutIcon, } from "@bitwarden/auth/angular"; import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum"; -import { LockV2Component } from "@bitwarden/key-management/angular"; +import { LockV2Component } from "@bitwarden/key-management"; import { twofactorRefactorSwap } from "../../../../libs/angular/src/utils/two-factor-component-refactor-route-swap"; import { AccessibilityCookieComponent } from "../auth/accessibility-cookie.component"; diff --git a/apps/desktop/src/app/services/services.module.ts b/apps/desktop/src/app/services/services.module.ts index 572b6348a58..6d9388f9b37 100644 --- a/apps/desktop/src/app/services/services.module.ts +++ b/apps/desktop/src/app/services/services.module.ts @@ -90,8 +90,8 @@ import { KeyService as KeyServiceAbstraction, BiometricStateService, BiometricsService, + LockComponentService, } from "@bitwarden/key-management"; -import { LockComponentService } from "@bitwarden/key-management/angular"; import { DesktopLoginApprovalComponentService } from "../../auth/login/desktop-login-approval-component.service"; import { DesktopLoginComponentService } from "../../auth/login/desktop-login-component.service"; diff --git a/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.spec.ts b/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.spec.ts index 2d60cdeb663..afedb9e9d6d 100644 --- a/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.spec.ts +++ b/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.spec.ts @@ -10,8 +10,12 @@ import { VaultTimeoutSettingsService } from "@bitwarden/common/abstractions/vaul import { DeviceType } from "@bitwarden/common/enums"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { UserId } from "@bitwarden/common/types/guid"; -import { KeyService, BiometricsService } from "@bitwarden/key-management"; -import { BiometricsDisableReason, UnlockOptions } from "@bitwarden/key-management/angular"; +import { + KeyService, + BiometricsService, + BiometricsDisableReason, + UnlockOptions, +} from "@bitwarden/key-management"; import { DesktopLockComponentService } from "./desktop-lock-component.service"; diff --git a/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.ts b/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.ts index 76232fd3196..e963e371e45 100644 --- a/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.ts +++ b/apps/desktop/src/key-management/lock/services/desktop-lock-component.service.ts @@ -10,12 +10,13 @@ import { DeviceType } from "@bitwarden/common/enums"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { KeySuffixOptions } from "@bitwarden/common/platform/enums"; import { UserId } from "@bitwarden/common/types/guid"; -import { KeyService, BiometricsService } from "@bitwarden/key-management"; import { + KeyService, + BiometricsService, BiometricsDisableReason, LockComponentService, UnlockOptions, -} from "@bitwarden/key-management/angular"; +} from "@bitwarden/key-management"; export class DesktopLockComponentService implements LockComponentService { private readonly userDecryptionOptionsService = inject(UserDecryptionOptionsServiceAbstraction); diff --git a/apps/desktop/tsconfig.json b/apps/desktop/tsconfig.json index da61ef22dd4..2d9de5fee49 100644 --- a/apps/desktop/tsconfig.json +++ b/apps/desktop/tsconfig.json @@ -29,7 +29,6 @@ "@bitwarden/importer/core": ["../../libs/importer/src"], "@bitwarden/importer/ui": ["../../libs/importer/src/components"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/node/*": ["../../libs/node/src/*"], "@bitwarden/platform": ["../../libs/platform/src"], "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"], diff --git a/apps/web/src/app/core/core.module.ts b/apps/web/src/app/core/core.module.ts index 8f21dfa2c8b..a7a3b59376e 100644 --- a/apps/web/src/app/core/core.module.ts +++ b/apps/web/src/app/core/core.module.ts @@ -90,8 +90,8 @@ import { KdfConfigService, KeyService as KeyServiceAbstraction, BiometricsService, + LockComponentService, } from "@bitwarden/key-management"; -import { LockComponentService } from "@bitwarden/key-management/angular"; import { flagEnabled } from "../../utils/flags"; import { PolicyListService } from "../admin-console/core/policy-list.service"; diff --git a/apps/web/src/app/key-management/lock/services/web-lock-component.service.ts b/apps/web/src/app/key-management/lock/services/web-lock-component.service.ts index dc124983c9a..cd030b11b6a 100644 --- a/apps/web/src/app/key-management/lock/services/web-lock-component.service.ts +++ b/apps/web/src/app/key-management/lock/services/web-lock-component.service.ts @@ -6,7 +6,7 @@ import { UserDecryptionOptionsServiceAbstraction, } from "@bitwarden/auth/common"; import { UserId } from "@bitwarden/common/types/guid"; -import { LockComponentService, UnlockOptions } from "@bitwarden/key-management/angular"; +import { LockComponentService, UnlockOptions } from "@bitwarden/key-management"; export class WebLockComponentService implements LockComponentService { private readonly userDecryptionOptionsService = inject(UserDecryptionOptionsServiceAbstraction); diff --git a/apps/web/src/app/oss-routing.module.ts b/apps/web/src/app/oss-routing.module.ts index b5708fcf92f..fa22e0690c7 100644 --- a/apps/web/src/app/oss-routing.module.ts +++ b/apps/web/src/app/oss-routing.module.ts @@ -39,7 +39,7 @@ import { LoginDecryptionOptionsComponent, } from "@bitwarden/auth/angular"; import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum"; -import { LockV2Component } from "@bitwarden/key-management/angular"; +import { LockV2Component } from "@bitwarden/key-management"; import { twofactorRefactorSwap } from "../../../../libs/angular/src/utils/two-factor-component-refactor-route-swap"; import { flagEnabled, Flags } from "../utils/flags"; diff --git a/apps/web/tsconfig.json b/apps/web/tsconfig.json index 678db7c4af5..3799945ea98 100644 --- a/apps/web/tsconfig.json +++ b/apps/web/tsconfig.json @@ -25,7 +25,6 @@ "@bitwarden/importer/core": ["../../libs/importer/src"], "@bitwarden/importer/ui": ["../../libs/importer/src/components"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/platform": ["../../libs/platform/src"], "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"], "@bitwarden/tools-card": ["../../libs/tools/card/src"], diff --git a/bitwarden_license/bit-cli/tsconfig.json b/bitwarden_license/bit-cli/tsconfig.json index 92a206f44db..e3d6cc5c7b7 100644 --- a/bitwarden_license/bit-cli/tsconfig.json +++ b/bitwarden_license/bit-cli/tsconfig.json @@ -24,7 +24,6 @@ "@bitwarden/generator-history": ["../../libs/tools/generator/extensions/history/src"], "@bitwarden/generator-navigation": ["../../libs/tools/generator/extensions/navigation/src"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/vault-export-core": [ "../../libs/tools/export/vault-export/vault-export-core/src" ], diff --git a/bitwarden_license/bit-common/tsconfig.json b/bitwarden_license/bit-common/tsconfig.json index a0a44f2ab30..03f3bd2d2f1 100644 --- a/bitwarden_license/bit-common/tsconfig.json +++ b/bitwarden_license/bit-common/tsconfig.json @@ -23,7 +23,6 @@ "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"], "@bitwarden/tools-card": ["../../libs/tools/card/src"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/platform": ["../../libs/platform/src"], "@bitwarden/vault": ["../../libs/vault/src"], "@bitwarden/web-vault/*": ["../../apps/web/src/*"], diff --git a/bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts b/bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts index 760877ff8bc..6899d6f26ba 100644 --- a/bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts +++ b/bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts @@ -17,7 +17,7 @@ import { LogService } from "@bitwarden/common/platform/abstractions/log.service" import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { ValidationService } from "@bitwarden/common/platform/abstractions/validation.service"; import { TableDataSource, NoItemsModule, ToastService } from "@bitwarden/components"; -import { KeyService } from "@bitwarden/key-management"; +import { KeyManagementPipesModule, KeyService } from "@bitwarden/key-management"; import { Devices } from "@bitwarden/web-vault/app/admin-console/icons"; import { LooseComponentsModule } from "@bitwarden/web-vault/app/shared"; import { SharedModule } from "@bitwarden/web-vault/app/shared/shared.module"; @@ -41,7 +41,7 @@ import { SharedModule } from "@bitwarden/web-vault/app/shared/shared.module"; ], }), ] satisfies SafeProvider[], - imports: [SharedModule, NoItemsModule, LooseComponentsModule], + imports: [SharedModule, NoItemsModule, LooseComponentsModule, KeyManagementPipesModule], }) export class DeviceApprovalsComponent implements OnInit, OnDestroy { tableDataSource = new TableDataSource(); diff --git a/bitwarden_license/bit-web/tsconfig.json b/bitwarden_license/bit-web/tsconfig.json index c4304ec2bd9..09de92d355d 100644 --- a/bitwarden_license/bit-web/tsconfig.json +++ b/bitwarden_license/bit-web/tsconfig.json @@ -24,7 +24,6 @@ "@bitwarden/importer/core": ["../../libs/importer/src"], "@bitwarden/importer/ui": ["../../libs/importer/src/components"], "@bitwarden/key-management": ["../../libs/key-management/src"], - "@bitwarden/key-management/angular": ["../../libs/key-management/src/angular"], "@bitwarden/platform": ["../../libs/platform/src"], "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"], "@bitwarden/tools-card": ["../../libs/tools/card/src"], diff --git a/libs/angular/src/jslib.module.ts b/libs/angular/src/jslib.module.ts index 4f5a8f6673c..c2214c85154 100644 --- a/libs/angular/src/jslib.module.ts +++ b/libs/angular/src/jslib.module.ts @@ -52,7 +52,6 @@ import { SearchPipe } from "./pipes/search.pipe"; import { UserNamePipe } from "./pipes/user-name.pipe"; import { UserTypePipe } from "./pipes/user-type.pipe"; import { EllipsisPipe } from "./platform/pipes/ellipsis.pipe"; -import { FingerprintPipe } from "./platform/pipes/fingerprint.pipe"; import { I18nPipe } from "./platform/pipes/i18n.pipe"; import { PasswordStrengthComponent } from "./tools/password-strength/password-strength.component"; import { IconComponent } from "./vault/components/icon.component"; @@ -111,7 +110,6 @@ import { IconComponent } from "./vault/components/icon.component"; PasswordStrengthComponent, UserTypePipe, IfFeatureDirective, - FingerprintPipe, AddAccountCreditDialogComponent, InvoicesComponent, NoInvoicesComponent, @@ -146,7 +144,6 @@ import { IconComponent } from "./vault/components/icon.component"; PasswordStrengthComponent, UserTypePipe, IfFeatureDirective, - FingerprintPipe, AddAccountCreditDialogComponent, InvoicesComponent, NoInvoicesComponent, @@ -161,7 +158,6 @@ import { IconComponent } from "./vault/components/icon.component"; SearchPipe, UserNamePipe, UserTypePipe, - FingerprintPipe, PluralizePipe, ], }) diff --git a/libs/key-management/src/angular/index.ts b/libs/key-management/src/angular/index.ts deleted file mode 100644 index 93a2060ed2e..00000000000 --- a/libs/key-management/src/angular/index.ts +++ /dev/null @@ -1,10 +0,0 @@ -/** - * This barrel file should only contain Angular exports - */ - -export { LockV2Component } from "./lock/components/lock.component"; -export { - LockComponentService, - BiometricsDisableReason, - UnlockOptions, -} from "./lock/services/lock-component.service"; diff --git a/libs/key-management/src/index.ts b/libs/key-management/src/index.ts index 1734d857a0c..49094e25035 100644 --- a/libs/key-management/src/index.ts +++ b/libs/key-management/src/index.ts @@ -19,3 +19,13 @@ export { DefaultKdfConfigService } from "./kdf-config.service"; export { KdfType } from "./enums/kdf-type.enum"; export * from "./user-asymmetric-key-regeneration"; + +export { LockV2Component } from "./lock/components/lock.component"; +export { + LockComponentService, + BiometricsDisableReason, + UnlockOptions, +} from "./lock/services/lock-component.service"; + +export { FingerprintPipe } from "./pipes/fingerprint.pipe"; +export { KeyManagementPipesModule } from "./pipes/key-management-pipes.module"; diff --git a/libs/key-management/src/angular/lock/components/lock.component.html b/libs/key-management/src/lock/components/lock.component.html similarity index 100% rename from libs/key-management/src/angular/lock/components/lock.component.html rename to libs/key-management/src/lock/components/lock.component.html diff --git a/libs/key-management/src/angular/lock/components/lock.component.ts b/libs/key-management/src/lock/components/lock.component.ts similarity index 98% rename from libs/key-management/src/angular/lock/components/lock.component.ts rename to libs/key-management/src/lock/components/lock.component.ts index e9fbdf4cb8b..8ad65af2345 100644 --- a/libs/key-management/src/angular/lock/components/lock.component.ts +++ b/libs/key-management/src/lock/components/lock.component.ts @@ -39,12 +39,10 @@ import { IconButtonModule, ToastService, } from "@bitwarden/components"; -import { - KeyService, - BiometricStateService, - UserAsymmetricKeysRegenerationService, -} from "@bitwarden/key-management"; +import { KeyService } from "../../abstractions/key.service"; +import { BiometricStateService } from "../../biometrics/biometric-state.service"; +import { UserAsymmetricKeysRegenerationService } from "../../user-asymmetric-key-regeneration/abstractions/user-asymmetric-key-regeneration.service"; import { UnlockOption, LockComponentService, @@ -66,8 +64,8 @@ const clientTypeToSuccessRouteRecord: Partial> = { standalone: true, imports: [ CommonModule, - JslibModule, ReactiveFormsModule, + JslibModule, ButtonModule, FormFieldModule, AsyncActionsModule, diff --git a/libs/key-management/src/angular/lock/services/lock-component.service.ts b/libs/key-management/src/lock/services/lock-component.service.ts similarity index 100% rename from libs/key-management/src/angular/lock/services/lock-component.service.ts rename to libs/key-management/src/lock/services/lock-component.service.ts diff --git a/libs/angular/src/platform/pipes/fingerprint.pipe.ts b/libs/key-management/src/pipes/fingerprint.pipe.ts similarity index 91% rename from libs/angular/src/platform/pipes/fingerprint.pipe.ts rename to libs/key-management/src/pipes/fingerprint.pipe.ts index 8f1a07cfd6b..2770bc7502d 100644 --- a/libs/angular/src/platform/pipes/fingerprint.pipe.ts +++ b/libs/key-management/src/pipes/fingerprint.pipe.ts @@ -1,7 +1,8 @@ import { Pipe } from "@angular/core"; import { Utils } from "@bitwarden/common/platform/misc/utils"; -import { KeyService } from "@bitwarden/key-management"; + +import { KeyService } from "../abstractions/key.service"; @Pipe({ name: "fingerprint", diff --git a/libs/key-management/src/pipes/key-management-pipes.module.ts b/libs/key-management/src/pipes/key-management-pipes.module.ts new file mode 100644 index 00000000000..9ac7b815834 --- /dev/null +++ b/libs/key-management/src/pipes/key-management-pipes.module.ts @@ -0,0 +1,11 @@ +import { NgModule } from "@angular/core"; + +import { FingerprintPipe } from "./fingerprint.pipe"; + +@NgModule({ + imports: [], + declarations: [FingerprintPipe], + providers: [], + exports: [FingerprintPipe], +}) +export class KeyManagementPipesModule {} diff --git a/tsconfig.json b/tsconfig.json index 91b4ee7dd6b..47b561e0829 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -33,7 +33,6 @@ "@bitwarden/importer/core": ["./libs/importer/src"], "@bitwarden/importer/ui": ["./libs/importer/src/components"], "@bitwarden/key-management": ["./libs/key-management/src"], - "@bitwarden/key-management/angular": ["./libs/key-management/src/angular"], "@bitwarden/platform": ["./libs/platform/src"], "@bitwarden/send-ui": ["./libs/tools/send/send-ui/src"], "@bitwarden/tools-card": ["./libs/tools/card/src"],