[PS-2320] Import API service refactor (#4529)

* Extract import methods from ApiService

Removed methods from ApiService impl and abstraction
Create import-api.service impl and abstraction
Moved import.service into abstractions/import/import.service.abstraction
Moved import.service into services/import/import.service
Change imports to use new services

* Fix import for tests

* Fix imports for CLI

* Fix imports for web

* Fix ModuleImports and dependencies

* Mark ImportApiService methods as async

apps/cli/src/bw.ts

@@ -5,6 +5,7 @@ import * as program from "commander";
 import * as jsdom from "jsdom";
 
 import { InternalFolderService } from "@bitwarden/common/abstractions/folder/folder.service.abstraction";
+import { ImportApiServiceAbstraction } from "@bitwarden/common/abstractions/import/import-api.service.abstraction";
 import { OrganizationUserService } from "@bitwarden/common/abstractions/organization-user/organization-user.service";
 import { OrganizationApiServiceAbstraction } from "@bitwarden/common/abstractions/organization/organization-api.service.abstraction";
 import { ClientType } from "@bitwarden/common/enums/clientType";
@@ -27,7 +28,8 @@ import { ExportService } from "@bitwarden/common/services/export.service";
 import { FileUploadService } from "@bitwarden/common/services/fileUpload.service";
 import { FolderApiService } from "@bitwarden/common/services/folder/folder-api.service";
 import { FolderService } from "@bitwarden/common/services/folder/folder.service";
-import { ImportService } from "@bitwarden/common/services/import.service";
+import { ImportApiService } from "@bitwarden/common/services/import/import-api.service";
+import { ImportService } from "@bitwarden/common/services/import/import.service";
 import { KeyConnectorService } from "@bitwarden/common/services/keyConnector.service";
 import { MemoryStorageService } from "@bitwarden/common/services/memoryStorage.service";
 import { NoopMessagingService } from "@bitwarden/common/services/noopMessaging.service";
@@ -94,6 +96,7 @@ export class Main {
   containerService: ContainerService;
   auditService: AuditService;
   importService: ImportService;
+  importApiService: ImportApiServiceAbstraction;
   exportService: ExportService;
   searchService: SearchService;
   cryptoFunctionService: NodeCryptoFunctionService;
@@ -339,10 +342,12 @@ export class Main {
 
     this.totpService = new TotpService(this.cryptoFunctionService, this.logService);
 
+    this.importApiService = new ImportApiService(this.apiService);
+
     this.importService = new ImportService(
       this.cipherService,
       this.folderService,
-      this.apiService,
+      this.importApiService,
       this.i18nService,
       this.collectionService,
       this.cryptoService

apps/cli/src/commands/import.command.ts

@@ -1,7 +1,7 @@
 import * as program from "commander";
 import * as inquirer from "inquirer";
 
-import { ImportService } from "@bitwarden/common/abstractions/import.service";
+import { ImportService } from "@bitwarden/common/abstractions/import/import.service.abstraction";
 import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
 import { ImportType } from "@bitwarden/common/enums/importOptions";
 import { Importer } from "@bitwarden/common/importers/importer";

apps/web/src/app/organizations/tools/import-export/org-import-export.module.ts

@@ -6,8 +6,10 @@ import { CollectionService } from "@bitwarden/common/abstractions/collection.ser
 import { CryptoService } from "@bitwarden/common/abstractions/crypto.service";
 import { FolderService } from "@bitwarden/common/abstractions/folder/folder.service.abstraction";
 import { I18nService } from "@bitwarden/common/abstractions/i18n.service";
-import { ImportService as ImportServiceAbstraction } from "@bitwarden/common/abstractions/import.service";
-import { ImportService } from "@bitwarden/common/services/import.service";
+import { ImportApiServiceAbstraction } from "@bitwarden/common/abstractions/import/import-api.service.abstraction";
+import { ImportService as ImportServiceAbstraction } from "@bitwarden/common/abstractions/import/import.service.abstraction";
+import { ImportApiService } from "@bitwarden/common/services/import/import-api.service";
+import { ImportService } from "@bitwarden/common/services/import/import.service";
 
 import { LooseComponentsModule, SharedModule } from "../../../shared";
 
@@ -19,13 +21,18 @@ import { OrganizationImportComponent } from "./org-import.component";
   imports: [SharedModule, LooseComponentsModule, OrganizationImportExportRoutingModule],
   declarations: [OrganizationImportComponent, OrganizationExportComponent],
   providers: [
+    {
+      provide: ImportApiServiceAbstraction,
+      useClass: ImportApiService,
+      deps: [ApiService],
+    },
     {
       provide: ImportServiceAbstraction,
       useClass: ImportService,
       deps: [
         CipherService,
         FolderService,
-        ApiService,
+        ImportApiServiceAbstraction,
         I18nService,
         CollectionService,
         CryptoService,

apps/web/src/app/organizations/tools/import-export/org-import.component.ts

@@ -3,7 +3,7 @@ import { ActivatedRoute, Router } from "@angular/router";
 
 import { ModalService } from "@bitwarden/angular/services/modal.service";
 import { I18nService } from "@bitwarden/common/abstractions/i18n.service";
-import { ImportService } from "@bitwarden/common/abstractions/import.service";
+import { ImportService } from "@bitwarden/common/abstractions/import/import.service.abstraction";
 import { LogService } from "@bitwarden/common/abstractions/log.service";
 import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
 import { PlatformUtilsService } from "@bitwarden/common/abstractions/platformUtils.service";

apps/web/src/app/tools/import-export/import-export.module.ts

@@ -6,8 +6,10 @@ import { CollectionService } from "@bitwarden/common/abstractions/collection.ser
 import { CryptoService } from "@bitwarden/common/abstractions/crypto.service";
 import { FolderService } from "@bitwarden/common/abstractions/folder/folder.service.abstraction";
 import { I18nService } from "@bitwarden/common/abstractions/i18n.service";
-import { ImportService as ImportServiceAbstraction } from "@bitwarden/common/abstractions/import.service";
-import { ImportService } from "@bitwarden/common/services/import.service";
+import { ImportApiServiceAbstraction } from "@bitwarden/common/abstractions/import/import-api.service.abstraction";
+import { ImportService as ImportServiceAbstraction } from "@bitwarden/common/abstractions/import/import.service.abstraction";
+import { ImportApiService } from "@bitwarden/common/services/import/import-api.service";
+import { ImportService } from "@bitwarden/common/services/import/import.service";
 
 import { LooseComponentsModule, SharedModule } from "../../shared";
 
@@ -20,13 +22,18 @@ import { ImportComponent } from "./import.component";
   imports: [SharedModule, LooseComponentsModule, ImportExportRoutingModule],
   declarations: [ImportComponent, ExportComponent, FilePasswordPromptComponent],
   providers: [
+    {
+      provide: ImportApiServiceAbstraction,
+      useClass: ImportApiService,
+      deps: [ApiService],
+    },
     {
       provide: ImportServiceAbstraction,
       useClass: ImportService,
       deps: [
         CipherService,
         FolderService,
-        ApiService,
+        ImportApiServiceAbstraction,
         I18nService,
         CollectionService,
         CryptoService,

apps/web/src/app/tools/import-export/import.component.ts

@@ -6,7 +6,7 @@ import Swal, { SweetAlertIcon } from "sweetalert2";
 
 import { ModalService } from "@bitwarden/angular/services/modal.service";
 import { I18nService } from "@bitwarden/common/abstractions/i18n.service";
-import { ImportService } from "@bitwarden/common/abstractions/import.service";
+import { ImportService } from "@bitwarden/common/abstractions/import/import.service.abstraction";
 import { LogService } from "@bitwarden/common/abstractions/log.service";
 import { PlatformUtilsService } from "@bitwarden/common/abstractions/platformUtils.service";
 import { PolicyService } from "@bitwarden/common/abstractions/policy/policy.service.abstraction";