bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 05:13:29 +00:00
Code Issues Releases Wiki Activity

[PS-1222] Remove appBlurClick throughout the popup and web code (#3208)

Browse Source 
* Remove appBlurClick throughout the popup code

`appBlurClick` leads to focus being lost/reset for assistive technology users. It should not be necessary in any case - if focus does need to move after an action, explicitly set it somewhere programmatically using `focus()` rather than relying on browser heuristics

* Remove now redundant blur-click directive
This commit is contained in:
Patrick H. Lauke
2022-08-17 09:42:26 +01:00
committed by GitHub
parent e7da2f0c22
commit babfa30c68
4 changed files with 2 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/angular/src/directives/blur-click.directive.ts
View File

@@ -1,12 +0,0 @@
import { Directive, ElementRef, HostListener } from "@angular/core";
@Directive({
selector: "[appBlurClick]",
})
export class BlurClickDirective {
constructor(private el: ElementRef) {}
@HostListener("click") onClick() {
this.el.nativeElement.blur();
}
}

3
libs/angular/src/jslib.module.ts
View File

@@ -11,7 +11,6 @@ import { A11yInvalidDirective } from "./directives/a11y-invalid.directive";
import { A11yTitleDirective } from "./directives/a11y-title.directive";
import { ApiActionDirective } from "./directives/api-action.directive";
import { AutofocusDirective } from "./directives/autofocus.directive";
import { BlurClickDirective } from "./directives/blur-click.directive";
import { BoxRowDirective } from "./directives/box-row.directive";
import { FallbackSrcDirective } from "./directives/fallback-src.directive";
import { InputStripSpacesDirective } from "./directives/input-strip-spaces.directive";
@@ -48,7 +47,6 @@ import { PasswordStrengthComponent } from "./shared/components/password-strength
ApiActionDirective,
AutofocusDirective,
AvatarComponent,
BlurClickDirective,
BoxRowDirective,
CalloutComponent,
ColorPasswordCountPipe,
@@ -78,7 +76,6 @@ import { PasswordStrengthComponent } from "./shared/components/password-strength
AutofocusDirective,
AvatarComponent,
BitwardenToastModule,
BlurClickDirective,
BoxRowDirective,
CalloutComponent,
ColorPasswordCountPipe,