From bbe64f4ae64d71c2b0564bcd5c627790d51d6177 Mon Sep 17 00:00:00 2001
From: Jake Fink <jfink@bitwarden.com>
Date: Wed, 21 Aug 2024 15:06:19 -0400
Subject: [PATCH] prevent computation of samlsigningoptions on change detection
 (#10399)

---
 .../bit-web/src/app/auth/sso/sso.component.ts          | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts
index 7a1510ef64..4074c20d9d 100644
--- a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts
+++ b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts
@@ -26,7 +26,6 @@ import { SsoConfigApi } from "@bitwarden/common/auth/models/api/sso-config.api";
 import { OrganizationSsoRequest } from "@bitwarden/common/auth/models/request/organization-sso.request";
 import { OrganizationSsoResponse } from "@bitwarden/common/auth/models/response/organization-sso.response";
 import { SsoConfigView } from "@bitwarden/common/auth/models/view/sso-config.view";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
 import { Utils } from "@bitwarden/common/platform/misc/utils";
@@ -61,6 +60,10 @@ export class SsoComponent implements OnInit, OnDestroy {
     "http://www.w3.org/2000/09/xmldsig#rsa-sha512",
   ];
 
+  readonly samlSigningAlgorithmOptions: SelectOptions[] = this.samlSigningAlgorithms.map(
+    (algorithm) => ({ name: algorithm, value: algorithm }),
+  );
+
   readonly saml2SigningBehaviourOptions: SelectOptions[] = [
     {
       name: "If IdP Wants Authn Requests Signed",
@@ -186,7 +189,6 @@ export class SsoComponent implements OnInit, OnDestroy {
     private i18nService: I18nService,
     private organizationService: OrganizationService,
     private organizationApiService: OrganizationApiServiceAbstraction,
-    private configService: ConfigService,
   ) {}
 
   async ngOnInit() {
@@ -330,10 +332,6 @@ export class SsoComponent implements OnInit, OnDestroy {
     return this.ssoConfigForm.get("keyConnectorUrl");
   }
 
-  get samlSigningAlgorithmOptions(): SelectOptions[] {
-    return this.samlSigningAlgorithms.map((algorithm) => ({ name: algorithm, value: algorithm }));
-  }
-
   /**
    * Shows any validation errors for the form by marking all controls as dirty and touched.
    * If nested form groups are found, they are also updated.