[AC-2520] Remove Unassigned Items Banner (#10042)

* chore: remove UnassignedItemsBanner feature flag, refs AC-2520

* chore: remove unassignedItemsBanner from web-header component, refs AC-2520

* chore: delete unassigned items banner service/api/spec, refs AC-2520

* chore: remove unassigned items banner messages (web), refs AC-2520

* chore: remove unassigned items banner messages (browser), refs AC-2520

* chore: remove unassigned items banner code from current tab (browser), refs AC-2520

* chore: remove state definition for unassigned items banner, refs AC-2520

* chore: revert state-definition removal, refs AC-2520

apps/browser/src/_locales/en/messages.json

@@ -3358,20 +3358,6 @@
   "passkeyRemoved": {
     "message": "Passkey removed"
   },
-  "unassignedItemsBannerNotice": {
-    "message": "Notice: Unassigned organization items are no longer visible in the All Vaults view and only accessible via the Admin Console."
-  },
-  "unassignedItemsBannerSelfHostNotice": {
-    "message": "Notice: On May 16, 2024, unassigned organization items will no longer be visible in the All Vaults view and will only be accessible via the Admin Console."
-  },
-  "unassignedItemsBannerCTAPartOne": {
-    "message": "Assign these items to a collection from the",
-    "description": "This will be part of a larger sentence, which will read like so: Assign these items to a collection from the Admin Console to make them visible."
-  },
-  "unassignedItemsBannerCTAPartTwo": {
-    "message": "to make them visible.",
-    "description": "This will be part of a larger sentence, which will read like so: Assign these items to a collection from the Admin Console to make them visible."
-  },
   "autofillSuggestions": {
     "message": "Auto-fill suggestions"
   },

apps/browser/src/vault/popup/components/vault/current-tab.component.html

@@ -36,44 +36,6 @@
   </div>
   <ng-container *ngIf="loaded">
     <app-vault-select (onVaultSelectionChanged)="load()"></app-vault-select>
-    <app-callout
-      *ngIf="
-        (unassignedItemsBannerEnabled$ | async) &&
-        (unassignedItemsBannerService.showBanner$ | async) &&
-        !(unassignedItemsBannerService.loading$ | async)
-      "
-      type="info"
-    >
-      <p>
-        {{ unassignedItemsBannerService.bannerText$ | async | i18n }}
-        {{ "unassignedItemsBannerCTAPartOne" | i18n }}
-        <a
-          [href]="unassignedItemsBannerService.adminConsoleUrl$ | async"
-          bitLink
-          linkType="contrast"
-          target="_blank"
-          rel="noreferrer"
-          >{{ "adminConsole" | i18n }}</a
-        >
-        {{ "unassignedItemsBannerCTAPartTwo" | i18n }}
-        <a
-          href="https://bitwarden.com/help/unassigned-vault-items-moved-to-admin-console"
-          bitLink
-          linkType="contrast"
-          target="_blank"
-          rel="noreferrer"
-          >{{ "learnMore" | i18n }}</a
-        >
-      </p>
-      <button
-        type="button"
-        class="btn primary callout-half"
-        appStopClick
-        (click)="unassignedItemsBannerService.hideBanner()"
-      >
-        {{ "gotIt" | i18n }}
-      </button>
-    </app-callout>
     <div class="box list" *ngIf="loginCiphers">
       <h2 class="box-header">
         {{ "typeLogins" | i18n }}

apps/browser/src/vault/popup/components/vault/current-tab.component.ts

@@ -3,14 +3,11 @@ import { Router } from "@angular/router";
 import { Subject, firstValueFrom, from, Subscription } from "rxjs";
 import { debounceTime, switchMap, takeUntil } from "rxjs/operators";
 
-import { UnassignedItemsBannerService } from "@bitwarden/angular/services/unassigned-items-banner.service";
 import { SearchService } from "@bitwarden/common/abstractions/search.service";
 import { OrganizationService } from "@bitwarden/common/admin-console/abstractions/organization/organization.service.abstraction";
 import { AutofillOverlayVisibility } from "@bitwarden/common/autofill/constants";
 import { AutofillSettingsServiceAbstraction } from "@bitwarden/common/autofill/services/autofill-settings.service";
-import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
 import { BroadcasterService } from "@bitwarden/common/platform/abstractions/broadcaster.service";
-import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
 import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
 import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
 import { Utils } from "@bitwarden/common/platform/misc/utils";
@@ -58,10 +55,6 @@ export class CurrentTabComponent implements OnInit, OnDestroy {
   private loadedTimeout: number;
   private searchTimeout: number;
 
-  protected unassignedItemsBannerEnabled$ = this.configService.getFeatureFlag$(
-    FeatureFlag.UnassignedItemsBanner,
-  );
-
   constructor(
     private platformUtilsService: PlatformUtilsService,
     private cipherService: CipherService,
@@ -78,8 +71,6 @@ export class CurrentTabComponent implements OnInit, OnDestroy {
     private organizationService: OrganizationService,
     private vaultFilterService: VaultFilterService,
     private vaultSettingsService: VaultSettingsService,
-    private configService: ConfigService,
-    protected unassignedItemsBannerService: UnassignedItemsBannerService,
   ) {}
 
   async ngOnInit() {