From bd7f362536d20ae0c7d280e2a7e10bc2cf6e6b2c Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Wed, 17 May 2023 09:10:14 +0200 Subject: [PATCH] [PM-2014] chore: rename everything from `fido2` to `webauthn` --- apps/web/src/app/auth/auth.module.ts | 6 +++--- .../src/app/auth/settings/fido2-login-settings/index.ts | 1 - .../create-credential-dialog.component.html | 0 .../create-credential-dialog.component.ts | 0 .../create-passkey-failed.icon.ts | 0 .../create-credential-dialog/create-passkey.icon.ts | 0 .../delete-credential-dialog.component.html | 0 .../delete-credential-dialog.component.ts | 0 .../app/auth/settings/webauthn-login-settings/index.ts | 1 + .../webauthn-login-settings.component.html} | 0 .../webauthn-login-settings.component.ts} | 6 +++--- .../webauthn-login-settings.module.ts} | 8 ++++---- apps/web/src/app/settings/change-password.component.html | 4 +++- apps/web/src/app/settings/change-password.component.ts | 4 ++-- 14 files changed, 16 insertions(+), 14 deletions(-) delete mode 100644 apps/web/src/app/auth/settings/fido2-login-settings/index.ts rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/create-credential-dialog/create-credential-dialog.component.html (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/create-credential-dialog/create-credential-dialog.component.ts (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/create-credential-dialog/create-passkey-failed.icon.ts (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/create-credential-dialog/create-passkey.icon.ts (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/delete-credential-dialog/delete-credential-dialog.component.html (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings => webauthn-login-settings}/delete-credential-dialog/delete-credential-dialog.component.ts (100%) create mode 100644 apps/web/src/app/auth/settings/webauthn-login-settings/index.ts rename apps/web/src/app/auth/settings/{fido2-login-settings/fido2-login-settings.component.html => webauthn-login-settings/webauthn-login-settings.component.html} (100%) rename apps/web/src/app/auth/settings/{fido2-login-settings/fido2-login-settings.component.ts => webauthn-login-settings/webauthn-login-settings.component.ts} (91%) rename apps/web/src/app/auth/settings/{fido2-login-settings/fido2-login-settings.module.ts => webauthn-login-settings/webauthn-login-settings.module.ts} (73%) diff --git a/apps/web/src/app/auth/auth.module.ts b/apps/web/src/app/auth/auth.module.ts index ed9b388ba54..fa89c37853b 100644 --- a/apps/web/src/app/auth/auth.module.ts +++ b/apps/web/src/app/auth/auth.module.ts @@ -1,14 +1,14 @@ import { NgModule } from "@angular/core"; import { CoreAuthModule } from "./core/core.module"; -import { Fido2LoginSettingsModule } from "./settings/fido2-login-settings"; +import { WebauthnLoginSettingsModule } from "./settings/webauthn-login-settings"; @NgModule({ - imports: [CoreAuthModule, Fido2LoginSettingsModule], + imports: [CoreAuthModule, WebauthnLoginSettingsModule], declarations: [], providers: [], exports: [ - Fido2LoginSettingsModule, // TODO: Remove when `app/settings/change-password.component.ts` has been moved to `app/auth/settings/.` + WebauthnLoginSettingsModule, // TODO: Remove when `app/settings/change-password.component.ts` has been moved to `app/auth/settings/.` ], }) export class AuthModule {} diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/index.ts b/apps/web/src/app/auth/settings/fido2-login-settings/index.ts deleted file mode 100644 index 76941437654..00000000000 --- a/apps/web/src/app/auth/settings/fido2-login-settings/index.ts +++ /dev/null @@ -1 +0,0 @@ -export * from "./fido2-login-settings.module"; diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-credential-dialog.component.html b/apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-credential-dialog.component.html similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-credential-dialog.component.html rename to apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-credential-dialog.component.html diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-credential-dialog.component.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-credential-dialog.component.ts similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-credential-dialog.component.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-credential-dialog.component.ts diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-passkey-failed.icon.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-passkey-failed.icon.ts similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-passkey-failed.icon.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-passkey-failed.icon.ts diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-passkey.icon.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-passkey.icon.ts similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/create-credential-dialog/create-passkey.icon.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/create-credential-dialog/create-passkey.icon.ts diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/delete-credential-dialog/delete-credential-dialog.component.html b/apps/web/src/app/auth/settings/webauthn-login-settings/delete-credential-dialog/delete-credential-dialog.component.html similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/delete-credential-dialog/delete-credential-dialog.component.html rename to apps/web/src/app/auth/settings/webauthn-login-settings/delete-credential-dialog/delete-credential-dialog.component.html diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/delete-credential-dialog/delete-credential-dialog.component.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/delete-credential-dialog/delete-credential-dialog.component.ts similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/delete-credential-dialog/delete-credential-dialog.component.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/delete-credential-dialog/delete-credential-dialog.component.ts diff --git a/apps/web/src/app/auth/settings/webauthn-login-settings/index.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/index.ts new file mode 100644 index 00000000000..87356770952 --- /dev/null +++ b/apps/web/src/app/auth/settings/webauthn-login-settings/index.ts @@ -0,0 +1 @@ +export * from "./webauthn-login-settings.module"; diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html b/apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.component.html similarity index 100% rename from apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.html rename to apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.component.html diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.component.ts similarity index 91% rename from apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.component.ts index b66d945ebf3..a628fb29235 100644 --- a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.component.ts +++ b/apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.component.ts @@ -10,13 +10,13 @@ import { openCreateCredentialDialog } from "./create-credential-dialog/create-cr import { openDeleteCredentialDialogComponent } from "./delete-credential-dialog/delete-credential-dialog.component"; @Component({ - selector: "app-fido2-login-settings", - templateUrl: "fido2-login-settings.component.html", + selector: "app-webauthn-login-settings", + templateUrl: "webauthn-login-settings.component.html", host: { "aria-live": "polite", }, }) -export class Fido2LoginSettingsComponent implements OnInit, OnDestroy { +export class WebauthnLoginSettingsComponent implements OnInit, OnDestroy { private destroy$ = new Subject(); protected readonly MaxCredentialCount = 5; diff --git a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.module.ts b/apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.module.ts similarity index 73% rename from apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.module.ts rename to apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.module.ts index 8fbdcdb9a9c..73e21387ec6 100644 --- a/apps/web/src/app/auth/settings/fido2-login-settings/fido2-login-settings.module.ts +++ b/apps/web/src/app/auth/settings/webauthn-login-settings/webauthn-login-settings.module.ts @@ -5,15 +5,15 @@ import { SharedModule } from "../../../shared/shared.module"; import { CreateCredentialDialogComponent } from "./create-credential-dialog/create-credential-dialog.component"; import { DeleteCredentialDialogComponent } from "./delete-credential-dialog/delete-credential-dialog.component"; -import { Fido2LoginSettingsComponent } from "./fido2-login-settings.component"; +import { WebauthnLoginSettingsComponent } from "./webauthn-login-settings.component"; @NgModule({ imports: [SharedModule, FormsModule, ReactiveFormsModule], declarations: [ - Fido2LoginSettingsComponent, + WebauthnLoginSettingsComponent, CreateCredentialDialogComponent, DeleteCredentialDialogComponent, ], - exports: [Fido2LoginSettingsComponent], + exports: [WebauthnLoginSettingsComponent], }) -export class Fido2LoginSettingsModule {} +export class WebauthnLoginSettingsModule {} diff --git a/apps/web/src/app/settings/change-password.component.html b/apps/web/src/app/settings/change-password.component.html index c6aa3590453..779091892e9 100644 --- a/apps/web/src/app/settings/change-password.component.html +++ b/apps/web/src/app/settings/change-password.component.html @@ -130,4 +130,6 @@ - + diff --git a/apps/web/src/app/settings/change-password.component.ts b/apps/web/src/app/settings/change-password.component.ts index ebdb1823b70..08f8854fe60 100644 --- a/apps/web/src/app/settings/change-password.component.ts +++ b/apps/web/src/app/settings/change-password.component.ts @@ -46,7 +46,7 @@ export class ChangePasswordComponent extends BaseChangePasswordComponent { checkForBreaches = true; characterMinimumMessage = ""; - protected showFido2LoginSettings$: Observable; + protected showWebauthnLoginSettings$: Observable; constructor( i18nService: I18nService, @@ -83,7 +83,7 @@ export class ChangePasswordComponent extends BaseChangePasswordComponent { } async ngOnInit() { - this.showFido2LoginSettings$ = from( + this.showWebauthnLoginSettings$ = from( this.configService.getFeatureFlagBool(FeatureFlag.PasswordlessLogin) );