bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[SG-742] (#4190)

Browse Source 
* Remove default landing on masterpassword page

* Remove rememberEmail state service value that isn't needed

* Remove last occurence of setRememberEmail

* Remove alwaysRememberEmail functionality

* Remove always remember email from browser and add option to

* Add extra spacing around remember email check

* [SG-884] Fix Remember Email functionality for Login with SSO (#4238)

* Add saveEmailSettings method to LoginService

* Add StateService as a dependency to LoginService

* Update login components to utilize new login service method for saving rememberedEmail
This commit is contained in:
Robyn MacCallum
2022-12-16 10:08:44 -05:00
committed by GitHub
parent 8bfe48ea73
commit c06c0f9f2c
15 changed files with 75 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/web/src/app/accounts/login/login-with-device.component.ts
View File

@@ -142,7 +142,7 @@ export class LoginWithDeviceComponent
this.router.navigate([this.forcePasswordResetRoute]);
}
} else {
await this.setRememberEmailValues();
await this.loginService.saveEmailSettings();
if (this.onSuccessfulLogin != null) {
this.onSuccessfulLogin();
}
@@ -202,12 +202,4 @@ export class LoginWithDeviceComponent
localHashedPassword
);
}
private async setRememberEmailValues() {
const rememberEmail = this.loginService.getRememberEmail();
const rememberedEmail = this.loginService.getEmail();
await this.stateService.setRememberEmail(rememberEmail);
await this.stateService.setRememberedEmail(rememberEmail ? rememberedEmail : null);
this.loginService.clearValues();
}
}

2
apps/web/src/app/accounts/login/login.component.html
View File

@@ -120,7 +120,7 @@
<div class="tw-mb-3">
<a
routerLink="/sso"
(click)="setFormValues()"
(click)="saveEmailSettings()"
bitButton
buttonType="secondary"
class="tw-w-full"

1
apps/web/src/app/accounts/login/login.component.ts
View File

@@ -192,7 +192,6 @@ export class LoginComponent extends BaseLoginComponent implements OnInit, OnDest
async submit() {
const rememberEmail = this.formGroup.value.rememberEmail;
await this.stateService.setRememberEmail(rememberEmail);
if (!rememberEmail) {
await this.stateService.setRememberedEmail(null);
}

1
apps/web/src/app/core/core.module.ts
View File

@@ -103,6 +103,7 @@ import { WebPlatformUtilsService } from "./web-platform-utils.service";
{
provide: LoginServiceAbstraction,
useClass: LoginService,
deps: [StateService],
},
],
})

17
apps/web/src/app/core/state/state.service.ts
View File

@@ -48,23 +48,6 @@ export class StateService extends BaseStateService<GlobalState, Account> {
await super.addAccount(account);
}
async getRememberEmail(options?: StorageOptions) {
return (
await this.getGlobals(this.reconcileOptions(options, await this.defaultOnDiskLocalOptions()))
)?.rememberEmail;
}
async setRememberEmail(value: boolean, options?: StorageOptions): Promise<void> {
const globals = await this.getGlobals(
this.reconcileOptions(options, await this.defaultOnDiskLocalOptions())
);
globals.rememberEmail = value;
await this.saveGlobals(
globals,
this.reconcileOptions(options, await this.defaultOnDiskLocalOptions())
);
}
async getEncryptedCiphers(options?: StorageOptions): Promise<{ [id: string]: CipherData }> {
options = this.reconcileOptions(options, await this.defaultInMemoryOptions());
return await super.getEncryptedCiphers(options);