diff --git a/apps/desktop/src/app/services/set-initial-password/desktop-set-initial-password.service.spec.ts b/apps/desktop/src/app/services/set-initial-password/desktop-set-initial-password.service.spec.ts index 3f53a2c4036..155c224dc6f 100644 --- a/apps/desktop/src/app/services/set-initial-password/desktop-set-initial-password.service.spec.ts +++ b/apps/desktop/src/app/services/set-initial-password/desktop-set-initial-password.service.spec.ts @@ -82,7 +82,8 @@ describe("DesktopSetInitialPasswordService", () => { }); /** - * @deprecated To be removed in PM-28143 + * @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties + * in the test setup above that are now un-used and can also be removed. */ describe("setInitialPassword(...)", () => { // Mock function parameters diff --git a/apps/web/src/app/auth/core/services/password-management/set-initial-password/web-set-initial-password.service.spec.ts b/apps/web/src/app/auth/core/services/password-management/set-initial-password/web-set-initial-password.service.spec.ts index 671d717ce11..3d452c23099 100644 --- a/apps/web/src/app/auth/core/services/password-management/set-initial-password/web-set-initial-password.service.spec.ts +++ b/apps/web/src/app/auth/core/services/password-management/set-initial-password/web-set-initial-password.service.spec.ts @@ -86,7 +86,8 @@ describe("WebSetInitialPasswordService", () => { }); /** - * @deprecated To be removed in PM-28143 + * @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties + * in the test setup above that are now un-used and can also be removed. */ describe("setInitialPassword(...)", () => { // Mock function parameters diff --git a/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.implementation.ts b/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.implementation.ts index badf777d01c..c399a85b452 100644 --- a/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.implementation.ts +++ b/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.implementation.ts @@ -50,7 +50,8 @@ export class DefaultSetInitialPasswordService implements SetInitialPasswordServi ) {} /** - * @deprecated To be removed in PM-28143 + * @deprecated To be removed in PM-28143. When you remove this, also check for any objects/methods + * in this default service that are now un-used and can also be removed. */ async setInitialPassword( credentials: SetInitialPasswordCredentials, diff --git a/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.spec.ts b/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.spec.ts index 022b85941a4..61369a82f16 100644 --- a/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.spec.ts +++ b/libs/angular/src/auth/password-management/set-initial-password/default-set-initial-password.service.spec.ts @@ -102,7 +102,8 @@ describe("DefaultSetInitialPasswordService", () => { }); /** - * @deprecated To be removed in PM-28143 + * @deprecated To be removed in PM-28143. When you remove this, check also if there are any imports/properties + * in the test setup above that are now un-used and can also be removed. */ describe("setInitialPassword(...)", () => { // Mock function parameters diff --git a/libs/auth/src/angular/input-password/input-password.component.ts b/libs/auth/src/angular/input-password/input-password.component.ts index e6d1688d716..b81e01156f1 100644 --- a/libs/auth/src/angular/input-password/input-password.component.ts +++ b/libs/auth/src/angular/input-password/input-password.component.ts @@ -364,6 +364,7 @@ export class InputPasswordComponent implements OnInit { return; } + // When you unwind the flag in PM-28143, also remove the ConfigService if it is un-used. const newApisWithInputPasswordFlagEnabled = await this.configService.getFeatureFlag( FeatureFlag.PM27086_UpdateAuthenticationApisForInputPassword, ); @@ -394,6 +395,10 @@ export class InputPasswordComponent implements OnInit { return passwordInputResult; } + /******************************************************************* + * The following code (within this `try`) to be removed in PM-28143 + *******************************************************************/ + // 4. Create cryptographic keys and build a PasswordInputResult object const newMasterKey = await this.keyService.makeMasterKey( newPassword, diff --git a/libs/auth/src/angular/input-password/input-password.stories.ts b/libs/auth/src/angular/input-password/input-password.stories.ts index b7d30a547e6..9e3a6419d2a 100644 --- a/libs/auth/src/angular/input-password/input-password.stories.ts +++ b/libs/auth/src/angular/input-password/input-password.stories.ts @@ -60,6 +60,7 @@ export default { getAllDecrypted: () => Promise.resolve([]), }, }, + // Can remove ConfigService from component and stories in PM-28143 (if it is no longer used) { provide: ConfigService, useValue: {