1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 00:03:56 +00:00

Remove password hint responses from API (#10523)

* Log reloading behavior

* Remove hints from responses.

changing password implies updating the hint, but no longer displays the old one. This is a security risk for shoulder surfing and breaks the escrow model we have where it is only shared via email when requested.

* Update change password hint label
This commit is contained in:
Matt Gibson
2024-08-23 10:51:42 -07:00
committed by GitHub
parent aa7c9685b6
commit c2829cd71b
7 changed files with 12 additions and 12 deletions

View File

@@ -51,6 +51,7 @@ export class WindowMain {
// Perform a hard reload of the render process by crashing it. This is suboptimal but ensures that all memory gets
// cleared, as the process itself will be completely garbage collected.
ipcMain.on("reload-process", async () => {
this.logService.info("Reloading render process");
// User might have changed theme, ensure the window is updated.
this.win.setBackgroundColor(await this.getBackgroundColor());
@@ -65,6 +66,7 @@ export class WindowMain {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.session.clearCache();
this.logService.info("Render process reloaded");
});
return new Promise<void>((resolve, reject) => {