bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

Remove password hint responses from API (#10523)

Browse Source 
* Log reloading behavior

* Remove hints from responses.

changing password implies updating the hint, but no longer displays the old one. This is a security risk for shoulder surfing and breaks the escrow model we have where it is only shared via email when requested.

* Update change password hint label
This commit is contained in:
Matt Gibson
2024-08-23 10:51:42 -07:00
committed by GitHub
parent aa7c9685b6
commit c2829cd71b
7 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/common/src/auth/models/request/update-profile.request.ts
View File

@@ -1,10 +1,8 @@
export class UpdateProfileRequest {
name: string;
masterPasswordHint: string;
culture = "en-US"; // deprecated
constructor(name: string, masterPasswordHint: string) {
constructor(name: string) {
this.name = name;
this.masterPasswordHint = masterPasswordHint ? masterPasswordHint : null;
}
}

2
libs/common/src/models/response/profile.response.ts
View File

@@ -10,7 +10,6 @@ export class ProfileResponse extends BaseResponse {
name: string;
email: string;
emailVerified: boolean;
masterPasswordHint: string;
premiumPersonally: boolean;
premiumFromOrganization: boolean;
culture: string;
@@ -32,7 +31,6 @@ export class ProfileResponse extends BaseResponse {
this.name = this.getResponseProperty("Name");
this.email = this.getResponseProperty("Email");
this.emailVerified = this.getResponseProperty("EmailVerified");
this.masterPasswordHint = this.getResponseProperty("MasterPasswordHint");
this.premiumPersonally = this.getResponseProperty("Premium");
this.premiumFromOrganization = this.getResponseProperty("PremiumFromOrganization");
this.culture = this.getResponseProperty("Culture");