From c37006c564a5b9ee1b984e65cbf1d012841faa67 Mon Sep 17 00:00:00 2001 From: pixls Date: Thu, 30 May 2024 13:32:25 -0400 Subject: [PATCH] Change website default value to empty string. (#9127) Fastmail API returns and error when passed a null value in forDomain. Empty string is the preferred blank option. Co-authored-by: yara --- .../generator/username/email-forwarders/fastmail-forwarder.ts | 4 +++- .../src/tools/generator/username/forwarders/fastmail.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libs/common/src/tools/generator/username/email-forwarders/fastmail-forwarder.ts b/libs/common/src/tools/generator/username/email-forwarders/fastmail-forwarder.ts index e8ea19afc95..85a7cf1c906 100644 --- a/libs/common/src/tools/generator/username/email-forwarders/fastmail-forwarder.ts +++ b/libs/common/src/tools/generator/username/email-forwarders/fastmail-forwarder.ts @@ -14,6 +14,8 @@ export class FastmailForwarder implements Forwarder { throw "Unable to obtain Fastmail masked email account ID."; } + const forDomain = (options.website || ""); + const requestInit: RequestInit = { redirect: "manual", cache: "no-store", @@ -35,7 +37,7 @@ export class FastmailForwarder implements Forwarder { "new-masked-email": { state: "enabled", description: "", - forDomain: options.website, + forDomain: forDomain, emailPrefix: options.fastmail.prefix, }, }, diff --git a/libs/common/src/tools/generator/username/forwarders/fastmail.ts b/libs/common/src/tools/generator/username/forwarders/fastmail.ts index e6ab28b59e3..0236e658fbe 100644 --- a/libs/common/src/tools/generator/username/forwarders/fastmail.ts +++ b/libs/common/src/tools/generator/username/forwarders/fastmail.ts @@ -12,7 +12,7 @@ import { Forwarders } from "../options/constants"; import { EmailPrefixOptions, ApiOptions } from "../options/forwarder-options"; export const DefaultFastmailOptions: ApiOptions & EmailPrefixOptions = Object.freeze({ - website: null, + website: "", domain: "", prefix: "", token: "",