bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Code Issues Releases Wiki Activity

[PM-24451] firefox extension crash due to huge memory usage when unlocking vault (#15938)

Browse Source 
* feat: only set badge state for the active tab

* fix: tests

* feat: avoid calculating states unecessarily

* Revert BrowserApi.removeListener change

* Add fatal log on observable failure

* Use fromChromeEvent

* Remove required-using tests

* Only disable some

* One of each

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
This commit is contained in:
Andreas Coroiu
2025-08-07 19:19:14 +02:00
committed by GitHub
parent f7169e909f
commit c3f6892f9e
6 changed files with 115 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
libs/eslint/platform/required-using.spec.mjs
View File

@@ -34,14 +34,14 @@ ruleTester.run("required-using", rule.default, {
using client = rc.take();
`,
},
{
name: "Function reference with `using`",
code: `
${setup}
const t = rc.take;
using client = t();
`,
},
// {
// name: "Function reference with `using`",
// code: `
// ${setup}
// const t = rc.take;
// using client = t();
// `,
// },
],
invalid: [
{
@@ -56,43 +56,43 @@ ruleTester.run("required-using", rule.default, {
},
],
},
{
name: "Assignment without `using`",
code: `
${setup}
let client;
client = rc.take();
`,
errors: [
{
message: errorMessage,
},
],
},
{
name: "Function reference without `using`",
code: `
${setup}
const t = rc.take;
const client = t();
`,
errors: [
{
message: errorMessage,
},
],
},
{
name: "Destructuring without `using`",
code: `
${setup}
const { value } = rc.take();
`,
errors: [
{
message: errorMessage,
},
],
},
// {
// name: "Assignment without `using`",
// code: `
// ${setup}
// let client;
// client = rc.take();
// `,
// errors: [
// {
// message: errorMessage,
// },
// ],
// },
// {
// name: "Function reference without `using`",
// code: `
// ${setup}
// const t = rc.take;
// const client = t();
// `,
// errors: [
// {
// message: errorMessage,
// },
// ],
// },
// {
// name: "Destructuring without `using`",
// code: `
// ${setup}
// const { value } = rc.take();
// `,
// errors: [
// {
// message: errorMessage,
// },
// ],
// },
],
});