From c444dfcb6062c9a4f7b8e46954c77dee48e84405 Mon Sep 17 00:00:00 2001 From: Vicki League Date: Tue, 24 Jun 2025 15:57:57 -0400 Subject: [PATCH] finish migrating button --- libs/components/src/button/button.component.ts | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/libs/components/src/button/button.component.ts b/libs/components/src/button/button.component.ts index ec8b82c7e33..f61caa8313c 100644 --- a/libs/components/src/button/button.component.ts +++ b/libs/components/src/button/button.component.ts @@ -1,6 +1,5 @@ -import { coerceBooleanProperty } from "@angular/cdk/coercion"; import { NgClass } from "@angular/common"; -import { Input, HostBinding, Component, model, computed, input } from "@angular/core"; +import { HostBinding, Component, model, computed, input, booleanAttribute } from "@angular/core"; import { toObservable, toSignal } from "@angular/core/rxjs-interop"; import { debounce, interval } from "rxjs"; @@ -70,7 +69,7 @@ export class ButtonComponent implements ButtonLikeAbstraction { "hover:tw-no-underline", "focus:tw-outline-none", ] - .concat(this.block ? ["tw-w-full", "tw-block"] : ["tw-inline-block"]) + .concat(this.block() ? ["tw-w-full", "tw-block"] : ["tw-inline-block"]) .concat(buttonStyles[this.buttonType() ?? "secondary"]) .concat( this.showDisabledStyles() || this.disabled() @@ -110,18 +109,7 @@ export class ButtonComponent implements ButtonLikeAbstraction { size = input("default"); - private _block = false; - - // TODO: Skipped for migration because: - // Accessor inputs cannot be migrated as they are too complex. - @Input() - get block(): boolean { - return this._block; - } - - set block(value: boolean | "") { - this._block = coerceBooleanProperty(value); - } + block = input(false, { transform: booleanAttribute }); loading = model(false);