bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Refactoring implementation

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-11 15:48:18 -05:00
parent 12077a2273
commit c4ca71337a
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -853,7 +853,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
unlockYourAccount: this.i18nService.translate("unlockYourAccountToViewMatchingLogins"), unlockYourAccount: this.i18nService.translate("unlockYourAccountToViewMatchingLogins"),
unlockAccount: this.i18nService.translate("unlockAccount"), unlockAccount: this.i18nService.translate("unlockAccount"),
fillCredentialsFor: this.i18nService.translate("fillCredentialsFor"), fillCredentialsFor: this.i18nService.translate("fillCredentialsFor"),
partialUsername: this.i18nService.translate("partialUsername"), username: this.i18nService.translate("username")?.toLowerCase(),
view: this.i18nService.translate("view"), view: this.i18nService.translate("view"),
noItemsToShow: this.i18nService.translate("noItemsToShow"), noItemsToShow: this.i18nService.translate("noItemsToShow"),
newItem: this.i18nService.translate("newItem"), newItem: this.i18nService.translate("newItem"),

12
apps/browser/src/autofill/overlay/inline-menu/pages/list/__snapshots__/autofill-inline-menu-list.spec.ts.snap
View File

@@ -67,7 +67,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, username1" aria-description="username, username1"
aria-label="fillCredentialsFor website login 1" aria-label="fillCredentialsFor website login 1"
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"
@@ -137,7 +137,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, username2" aria-description="username, username2"
aria-label="fillCredentialsFor website login 2" aria-label="fillCredentialsFor website login 2"
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"
@@ -206,7 +206,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, " aria-description="username, "
aria-label="fillCredentialsFor " aria-label="fillCredentialsFor "
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"
@@ -262,7 +262,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, username4" aria-description="username, username4"
aria-label="fillCredentialsFor website login 4" aria-label="fillCredentialsFor website login 4"
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"
@@ -347,7 +347,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, username5" aria-description="username, username5"
aria-label="fillCredentialsFor website login 5" aria-label="fillCredentialsFor website login 5"
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"
@@ -417,7 +417,7 @@ exports[`AutofillInlineMenuList initAutofillInlineMenuList the list of ciphers f
class="cipher-container" class="cipher-container"
> >
<button <button
aria-description="partialUsername, username6" aria-description="username, username6"
aria-label="fillCredentialsFor website login 6" aria-label="fillCredentialsFor website login 6"
class="fill-cipher-button" class="fill-cipher-button"
tabindex="-1" tabindex="-1"

2
apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts
View File

@@ -266,7 +266,7 @@ export class AutofillInlineMenuList extends AutofillInlineMenuPageElement {
); );
fillCipherElement.setAttribute( fillCipherElement.setAttribute(
"aria-description", "aria-description",
`${this.getTranslation("partialUsername")}, ${cipher.login.username}`, `${this.getTranslation("username")}, ${cipher.login.username}`,
); );
fillCipherElement.append(cipherIcon, cipherDetailsElement); fillCipherElement.append(cipherIcon, cipherDetailsElement);
fillCipherElement.addEventListener(EVENTS.CLICK, this.handleFillCipherClickEvent(cipher)); fillCipherElement.addEventListener(EVENTS.CLICK, this.handleFillCipherClickEvent(cipher));

2
apps/browser/src/autofill/spec/autofill-mocks.ts
View File

@@ -159,7 +159,7 @@ const overlayPagesTranslations = {
unlockYourAccount: "unlockYourAccount", unlockYourAccount: "unlockYourAccount",
unlockAccount: "unlockAccount", unlockAccount: "unlockAccount",
fillCredentialsFor: "fillCredentialsFor", fillCredentialsFor: "fillCredentialsFor",
partialUsername: "partialUsername", username: "username",
view: "view", view: "view",
noItemsToShow: "noItemsToShow", noItemsToShow: "noItemsToShow",
newItem: "newItem", newItem: "newItem",