bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Code Issues Releases Wiki Activity

[PM-2340] Enable use-lifecycle-interface (#5488)

Browse Source 
Enables one of the recommended rules of @angular-eslint. Since this rule was fairly trivial to fix and has no QA effects it seemed reasonable to migrate all code.
This commit is contained in:
Oscar Hinton
2024-08-02 19:59:38 +02:00
committed by GitHub
parent 0b6d9928a3
commit c50a9063bc
67 changed files with 187 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bitwarden_license/bit-web/src/app/app.component.ts
View File

@@ -1,4 +1,4 @@
import { Component } from "@angular/core";
import { Component, OnInit } from "@angular/core";
import { AppComponent as BaseAppComponent } from "@bitwarden/web-vault/app/app.component";
@@ -10,7 +10,7 @@ import { MaximumVaultTimeoutPolicy } from "./admin-console/policies/maximum-vaul
selector: "app-root",
templateUrl: "../../../../apps/web/src/app/app.component.html",
})
export class AppComponent extends BaseAppComponent {
export class AppComponent extends BaseAppComponent implements OnInit {
ngOnInit() {
super.ngOnInit();

4
bitwarden_license/bit-web/src/app/billing/providers/subscription/provider-subscription.component.ts
View File

@@ -1,4 +1,4 @@
import { Component } from "@angular/core";
import { Component, OnDestroy, OnInit } from "@angular/core";
import { ActivatedRoute } from "@angular/router";
import { Subject, concatMap, takeUntil } from "rxjs";
@@ -16,7 +16,7 @@ import { ToastService } from "@bitwarden/components";
selector: "app-provider-subscription",
templateUrl: "./provider-subscription.component.html",
})
export class ProviderSubscriptionComponent {
export class ProviderSubscriptionComponent implements OnInit, OnDestroy {
providerId: string;
subscription: ProviderSubscriptionResponse;

4
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-secrets.component.ts
View File

@@ -1,4 +1,4 @@
import { Component } from "@angular/core";
import { Component, OnInit } from "@angular/core";
import { ActivatedRoute } from "@angular/router";
import { combineLatest, combineLatestWith, filter, Observable, startWith, switchMap } from "rxjs";
@@ -31,7 +31,7 @@ import { ProjectService } from "../project.service";
selector: "sm-project-secrets",
templateUrl: "./project-secrets.component.html",
})
export class ProjectSecretsComponent {
export class ProjectSecretsComponent implements OnInit {
secrets$: Observable<SecretListView[]>;
private organizationId: string;

4
bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-dialog.component.ts
View File

@@ -1,5 +1,5 @@
import { DialogRef, DIALOG_DATA } from "@angular/cdk/dialog";
import { ChangeDetectorRef, Component, Inject, OnInit } from "@angular/core";
import { ChangeDetectorRef, Component, Inject, OnDestroy, OnInit } from "@angular/core";
import { FormControl, FormGroup, Validators } from "@angular/forms";
import { lastValueFrom, Subject, takeUntil } from "rxjs";
@@ -54,7 +54,7 @@ export interface SecretOperation {
@Component({
templateUrl: "./secret-dialog.component.html",
})
export class SecretDialogComponent implements OnInit {
export class SecretDialogComponent implements OnInit, OnDestroy {
loading = true;
projects: ProjectListView[];
addNewProject = false;

4
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts
View File

@@ -1,5 +1,5 @@
import { DialogRef, DIALOG_DATA } from "@angular/cdk/dialog";
import { Component, Inject } from "@angular/core";
import { Component, Inject, OnInit } from "@angular/core";
import { FormControl, FormGroup, Validators } from "@angular/forms";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
@@ -24,7 +24,7 @@ export interface ServiceAccountOperation {
@Component({
templateUrl: "./service-account-dialog.component.html",
})
export class ServiceAccountDialogComponent {
export class ServiceAccountDialogComponent implements OnInit {
protected formGroup = new FormGroup(
{
name: new FormControl("", {

7
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/event-logs/service-accounts-events.component.ts
View File

@@ -1,4 +1,4 @@
import { Component, OnDestroy } from "@angular/core";
import { Component, OnDestroy, OnInit } from "@angular/core";
import { ActivatedRoute } from "@angular/router";
import { Subject, takeUntil } from "rxjs";
@@ -16,7 +16,10 @@ import { ServiceAccountEventLogApiService } from "./service-account-event-log-ap
selector: "sm-service-accounts-events",
templateUrl: "./service-accounts-events.component.html",
})
export class ServiceAccountEventsComponent extends BaseEventsComponent implements OnDestroy {
export class ServiceAccountEventsComponent
extends BaseEventsComponent
implements OnInit, OnDestroy
{
exportFileName = "machine-account-events";
private destroy$ = new Subject<void>();
private serviceAccountId: string;