bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 22:03:36 +00:00
Code Issues Releases Wiki Activity

[PM-2340] Enable use-lifecycle-interface (#5488)

Browse Source 
Enables one of the recommended rules of @angular-eslint. Since this rule was fairly trivial to fix and has no QA effects it seemed reasonable to migrate all code.
This commit is contained in:
Oscar Hinton
2024-08-02 19:59:38 +02:00
committed by GitHub
parent 0b6d9928a3
commit c50a9063bc
67 changed files with 187 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/angular/src/auth/components/set-password.component.ts
View File

@@ -1,4 +1,4 @@
import { Directive } from "@angular/core";
import { Directive, OnInit } from "@angular/core";
import { ActivatedRoute, Router } from "@angular/router";
import { firstValueFrom, of } from "rxjs";
import { filter, first, switchMap, tap } from "rxjs/operators";
@@ -37,7 +37,7 @@ import { PasswordGenerationServiceAbstraction } from "@bitwarden/generator-legac
import { ChangePasswordComponent as BaseChangePasswordComponent } from "./change-password.component";
@Directive()
export class SetPasswordComponent extends BaseChangePasswordComponent {
export class SetPasswordComponent extends BaseChangePasswordComponent implements OnInit {
syncLoading = true;
showPassword = false;
hint = "";

4
libs/angular/src/auth/components/sso.component.ts
View File

@@ -1,4 +1,4 @@
import { Directive } from "@angular/core";
import { Directive, OnInit } from "@angular/core";
import { ActivatedRoute, NavigationExtras, Router } from "@angular/router";
import { firstValueFrom } from "rxjs";
import { first } from "rxjs/operators";
@@ -29,7 +29,7 @@ import { Utils } from "@bitwarden/common/platform/misc/utils";
import { PasswordGenerationServiceAbstraction } from "@bitwarden/generator-legacy";
@Directive()
export class SsoComponent {
export class SsoComponent implements OnInit {
identifier: string;
loggingIn = false;

4
libs/angular/src/auth/components/two-factor-auth/two-factor-auth-duo.component.ts
View File

@@ -1,6 +1,6 @@
import { DialogModule } from "@angular/cdk/dialog";
import { CommonModule } from "@angular/common";
import { Component, EventEmitter, Input, Output } from "@angular/core";
import { Component, EventEmitter, Input, OnInit, Output } from "@angular/core";
import { ReactiveFormsModule, FormsModule } from "@angular/forms";
import { JslibModule } from "@bitwarden/angular/jslib.module";
@@ -34,7 +34,7 @@ import {
],
providers: [I18nPipe],
})
export class TwoFactorAuthDuoComponent {
export class TwoFactorAuthDuoComponent implements OnInit {
@Output() token = new EventEmitter<string>();
@Input() providerData: any;

4
libs/angular/src/auth/components/two-factor-auth/two-factor-auth-email.component.ts
View File

@@ -1,6 +1,6 @@
import { DialogModule } from "@angular/cdk/dialog";
import { CommonModule } from "@angular/common";
import { Component, EventEmitter, Output } from "@angular/core";
import { Component, EventEmitter, OnInit, Output } from "@angular/core";
import { ReactiveFormsModule, FormsModule } from "@angular/forms";
import { JslibModule } from "@bitwarden/angular/jslib.module";
@@ -40,7 +40,7 @@ import {
],
providers: [I18nPipe],
})
export class TwoFactorAuthEmailComponent {
export class TwoFactorAuthEmailComponent implements OnInit {
@Output() token = new EventEmitter<string>();
twoFactorEmail: string = null;

4
libs/angular/src/auth/components/two-factor-auth/two-factor-auth-webauthn.component.ts
View File

@@ -1,6 +1,6 @@
import { DialogModule } from "@angular/cdk/dialog";
import { CommonModule } from "@angular/common";
import { Component, EventEmitter, Inject, Output } from "@angular/core";
import { Component, EventEmitter, Inject, OnDestroy, OnInit, Output } from "@angular/core";
import { ReactiveFormsModule, FormsModule } from "@angular/forms";
import { ActivatedRoute } from "@angular/router";
import { firstValueFrom } from "rxjs";
@@ -41,7 +41,7 @@ import {
],
providers: [I18nPipe],
})
export class TwoFactorAuthWebAuthnComponent {
export class TwoFactorAuthWebAuthnComponent implements OnInit, OnDestroy {
@Output() token = new EventEmitter<string>();
webAuthnReady = false;

4
libs/angular/src/auth/components/update-temp-password.component.ts
View File

@@ -1,4 +1,4 @@
import { Directive } from "@angular/core";
import { Directive, OnInit } from "@angular/core";
import { Router } from "@angular/router";
import { firstValueFrom, map } from "rxjs";
@@ -30,7 +30,7 @@ import { PasswordGenerationServiceAbstraction } from "@bitwarden/generator-legac
import { ChangePasswordComponent as BaseChangePasswordComponent } from "./change-password.component";
@Directive()
export class UpdateTempPasswordComponent extends BaseChangePasswordComponent {
export class UpdateTempPasswordComponent extends BaseChangePasswordComponent implements OnInit {
hint: string;
key: string;
enforcedPolicyOptions: MasterPasswordPolicyOptions;

4
libs/angular/src/directives/input-verbatim.directive.ts
View File

@@ -1,9 +1,9 @@
import { Directive, ElementRef, Input, Renderer2 } from "@angular/core";
import { Directive, ElementRef, Input, OnInit, Renderer2 } from "@angular/core";
@Directive({
selector: "[appInputVerbatim]",
})
export class InputVerbatimDirective {
export class InputVerbatimDirective implements OnInit {
@Input() set appInputVerbatim(condition: boolean | string) {
this.disableComplete = condition === "" || condition === true;
}