1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00

[PM-2340] Enable use-lifecycle-interface (#5488)

Enables one of the recommended rules of @angular-eslint. Since this rule was fairly trivial to fix and has no QA effects it seemed reasonable to migrate all code.
This commit is contained in:
Oscar Hinton
2024-08-02 19:59:38 +02:00
committed by GitHub
parent 0b6d9928a3
commit c50a9063bc
67 changed files with 187 additions and 130 deletions

View File

@@ -1,5 +1,5 @@
import { CommonModule } from "@angular/common";
import { Component, Input, OnInit } from "@angular/core";
import { Component, Input, OnDestroy, OnInit } from "@angular/core";
import { Observable, Subject, takeUntil } from "rxjs";
import { JslibModule } from "@bitwarden/angular/jslib.module";
@@ -45,7 +45,7 @@ import { ViewIdentitySectionsComponent } from "./view-identity-sections/view-ide
ViewIdentitySectionsComponent,
],
})
export class CipherViewComponent implements OnInit {
export class CipherViewComponent implements OnInit, OnDestroy {
@Input() cipher: CipherView;
organization$: Observable<Organization>;
folder$: Observable<FolderView>;

View File

@@ -1,5 +1,14 @@
import { CommonModule } from "@angular/common";
import { Component, EventEmitter, Input, OnInit, Output, ViewChild } from "@angular/core";
import {
AfterViewInit,
Component,
EventEmitter,
Input,
OnDestroy,
OnInit,
Output,
ViewChild,
} from "@angular/core";
import { FormBuilder, ReactiveFormsModule, Validators } from "@angular/forms";
import {
Observable,
@@ -80,7 +89,7 @@ const MY_VAULT_ID = "MyVault";
DialogModule,
],
})
export class AssignCollectionsComponent implements OnInit {
export class AssignCollectionsComponent implements OnInit, OnDestroy, AfterViewInit {
@ViewChild(BitSubmitDirective)
private bitSubmit: BitSubmitDirective;