From c57f439161ab2ab5dd6ac9ee2f39b040f5f0e570 Mon Sep 17 00:00:00 2001 From: Matt Gibson Date: Fri, 10 Oct 2025 10:09:36 -0700 Subject: [PATCH] Change name for playwright helpers to be more general --- .github/CODEOWNERS | 2 +- .../src/app/auth/login/example.play.spec.ts | 2 +- jest.config.js | 2 +- libs/playwright-scenes/README.md | 2 +- libs/playwright-scenes/jest.config.js | 4 ++-- libs/playwright-scenes/package.json | 2 +- libs/playwright-scenes/project.json | 18 +++++++++--------- package-lock.json | 8 ++++---- tsconfig.base.json | 2 +- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d7a2dc96d10..892fe0f5c0d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -219,4 +219,4 @@ apps/web/src/locales/en/messages.json **/jest.config.js @bitwarden/team-platform-dev **/project.jsons @bitwarden/team-platform-dev libs/pricing @bitwarden/team-billing-dev -libs/playwright-scenes @bitwarden/team-architecture +libs/playwright-helpers @bitwarden/team-architecture diff --git a/apps/web/src/app/auth/login/example.play.spec.ts b/apps/web/src/app/auth/login/example.play.spec.ts index 69e79f6cac1..3f8c6fe1ac4 100644 --- a/apps/web/src/app/auth/login/example.play.spec.ts +++ b/apps/web/src/app/auth/login/example.play.spec.ts @@ -1,6 +1,6 @@ import { test, expect } from "@playwright/test"; -import { Play, SingleUserRecipe } from "@bitwarden/playwright-scenes"; +import { Play, SingleUserRecipe } from "@bitwarden/playwright-helpers"; test("login with password", async ({ page }) => { using scene = await Play.scene(new SingleUserRecipe({ email: "test@example.com" })); diff --git a/jest.config.js b/jest.config.js index be0e77724b1..9a1079cc12f 100644 --- a/jest.config.js +++ b/jest.config.js @@ -59,7 +59,7 @@ module.exports = { "/libs/tools/send/send-ui/jest.config.js", "/libs/user-core/jest.config.js", "/libs/vault/jest.config.js", - "/libs/playwright-scenes/jest.config.js", + "/libs/playwright-helpers/jest.config.js", ], // Workaround for a memory leak that crashes tests in CI: diff --git a/libs/playwright-scenes/README.md b/libs/playwright-scenes/README.md index 5c2e4fcf432..a080d6104ec 100644 --- a/libs/playwright-scenes/README.md +++ b/libs/playwright-scenes/README.md @@ -1,4 +1,4 @@ -# playwright-scenes +# playwright-helpers Owned by: architecture diff --git a/libs/playwright-scenes/jest.config.js b/libs/playwright-scenes/jest.config.js index f758fcc3877..a2d98ee4db1 100644 --- a/libs/playwright-scenes/jest.config.js +++ b/libs/playwright-scenes/jest.config.js @@ -2,12 +2,12 @@ const sharedConfig = require("../../libs/shared/jest.config.angular"); module.exports = { ...sharedConfig, - displayName: "playwright-scenes", + displayName: "playwright-helpers", preset: "../../jest.preset.js", testEnvironment: "node", transform: { "^.+\\.[tj]s$": ["ts-jest", { tsconfig: "/tsconfig.spec.json" }], }, moduleFileExtensions: ["ts", "js", "html"], - coverageDirectory: "../../coverage/libs/playwright-scenes", + coverageDirectory: "../../coverage/libs/playwright-helpers", }; diff --git a/libs/playwright-scenes/package.json b/libs/playwright-scenes/package.json index f449ae09065..82fbbc543c3 100644 --- a/libs/playwright-scenes/package.json +++ b/libs/playwright-scenes/package.json @@ -1,5 +1,5 @@ { - "name": "@bitwarden/playwright-scenes", + "name": "@bitwarden/playwright-helpers", "version": "0.0.1", "description": "Framework for writing end-to-end playwright tests", "private": true, diff --git a/libs/playwright-scenes/project.json b/libs/playwright-scenes/project.json index 0fb3fb90485..eee0b8b4806 100644 --- a/libs/playwright-scenes/project.json +++ b/libs/playwright-scenes/project.json @@ -1,7 +1,7 @@ { - "name": "playwright-scenes", + "name": "playwright-helpers", "$schema": "../../node_modules/nx/schemas/project-schema.json", - "sourceRoot": "libs/playwright-scenes/src", + "sourceRoot": "libs/playwright-helpers/src", "projectType": "library", "tags": ["!dependsOn:common"], "targets": { @@ -9,25 +9,25 @@ "executor": "@nx/js:tsc", "outputs": ["{options.outputPath}"], "options": { - "outputPath": "dist/libs/playwright-scenes", - "main": "libs/playwright-scenes/src/index.ts", - "tsConfig": "libs/playwright-scenes/tsconfig.lib.json", - "assets": ["libs/playwright-scenes/*.md"], - "rootDir": "libs/playwright-scenes/src" + "outputPath": "dist/libs/playwright-helpers", + "main": "libs/playwright-helpers/src/index.ts", + "tsConfig": "libs/playwright-helpers/tsconfig.lib.json", + "assets": ["libs/playwright-helpers/*.md"], + "rootDir": "libs/playwright-helpers/src" } }, "lint": { "executor": "@nx/eslint:lint", "outputs": ["{options.outputFile}"], "options": { - "lintFilePatterns": ["libs/playwright-scenes/**/*.ts"] + "lintFilePatterns": ["libs/playwright-helpers/**/*.ts"] } }, "test": { "executor": "@nx/jest:jest", "outputs": ["{workspaceRoot}/coverage/{projectRoot}"], "options": { - "jestConfig": "libs/playwright-scenes/jest.config.js" + "jestConfig": "libs/playwright-helpers/jest.config.js" } }, "e2e": { diff --git a/package-lock.json b/package-lock.json index b96d006224d..d1f536351aa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -395,8 +395,8 @@ "version": "0.0.0", "license": "GPL-3.0" }, - "libs/playwright-scenes": { - "name": "@bitwarden/playwright-scenes", + "libs/playwright-helpers": { + "name": "@bitwarden/playwright-helpers", "version": "0.0.1", "license": "GPL-3.0" }, @@ -4690,8 +4690,8 @@ "resolved": "libs/platform", "link": true }, - "node_modules/@bitwarden/playwright-scenes": { - "resolved": "libs/playwright-scenes", + "node_modules/@bitwarden/playwright-helpers": { + "resolved": "libs/playwright-helpers", "link": true }, "node_modules/@bitwarden/pricing": { diff --git a/tsconfig.base.json b/tsconfig.base.json index 665df28455a..b62085d69da 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -49,7 +49,7 @@ "@bitwarden/nx-plugin": ["libs/nx-plugin/src/index.ts"], "@bitwarden/platform": ["./libs/platform/src"], "@bitwarden/platform/*": ["./libs/platform/src/*"], - "@bitwarden/playwright-scenes": ["libs/playwright-scenes/src/index.ts"], + "@bitwarden/playwright-helpers": ["libs/playwright-helpers/src/index.ts"], "@bitwarden/pricing": ["libs/pricing/src/index.ts"], "@bitwarden/send-ui": ["./libs/tools/send/send-ui/src"], "@bitwarden/serialization": ["libs/serialization/src/index.ts"],