bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-04 17:43:39 +00:00
Code Issues Releases Wiki Activity

[PM-3683] Remove ipcRenderer from electron-platform-utils (#6679)

Browse Source 
* [PM-3683] Remove ipcRenderer from electron-platform-utils

* FIx review comments

* Formatting

* Use isNullOrWhitespace
This commit is contained in:
Daniel García
2023-11-01 18:34:36 +01:00
committed by GitHub
parent a1729c97df
commit c592bcba80
9 changed files with 112 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
apps/desktop/src/platform/services/electron-platform-utils.service.ts
View File

@@ -1,5 +1,3 @@
import { ipcRenderer, shell } from "electron";
import { ClientType, DeviceType } from "@bitwarden/common/enums";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { MessagingService } from "@bitwarden/common/platform/abstractions/messaging.service";
@@ -8,7 +6,6 @@ import {
PlatformUtilsService,
} from "@bitwarden/common/platform/abstractions/platform-utils.service";
import { BiometricMessage, BiometricStorageAction } from "../../types/biometric-message";
import { isMacAppStore } from "../../utils";
import { ClipboardWriteMessage } from "../types/clipboard";
@@ -61,7 +58,7 @@ export class ElectronPlatformUtilsService implements PlatformUtilsService {
}
launchUri(uri: string, options?: any): void {
shell.openExternal(uri);
ipc.platform.launchUri(uri);
}
getApplicationVersion(): Promise<string> {
@@ -108,7 +105,7 @@ export class ElectronPlatformUtilsService implements PlatformUtilsService {
const clearing = options?.clearing === true;
const clearMs = options?.clearMs ?? null;
ipcRenderer.invoke("clipboard.write", {
ipc.platform.clipboard.write({
text: text,
password: (options?.allowHistory ?? false) === false, // default to false
} satisfies ClipboardWriteMessage);
@@ -123,13 +120,11 @@ export class ElectronPlatformUtilsService implements PlatformUtilsService {
}
readFromClipboard(): Promise<string> {
return ipcRenderer.invoke("clipboard.read");
return ipc.platform.clipboard.read();
}
async supportsBiometric(): Promise<boolean> {
return await ipcRenderer.invoke("biometric", {
action: BiometricStorageAction.OsSupported,
} as BiometricMessage);
return await ipc.platform.biometric.osSupported();
}
/** This method is used to authenticate the user presence _only_.
@@ -137,11 +132,7 @@ export class ElectronPlatformUtilsService implements PlatformUtilsService {
* biometric keys, which has a separate authentication mechanism.
* For biometric keys, invoke "keytar" with a biometric key suffix */
async authenticateBiometric(): Promise<boolean> {
const val = await ipcRenderer.invoke("biometric", {
action: "authenticate",
});
return val;
return await ipc.platform.biometric.authenticate();
}
supportsSecureStorage(): boolean {