1
0
mirror of https://github.com/bitwarden/browser synced 2026-03-02 03:21:19 +00:00

Eliminate standalone in libs/components (#19142)

* Eliminate last standalone in libs/components

* Fix annon layout
This commit is contained in:
Oscar Hinton
2026-02-26 18:48:41 +01:00
committed by GitHub
parent d8fdfdf559
commit c5fa1a5b04
15 changed files with 10 additions and 42 deletions

View File

@@ -1,4 +1,4 @@
import { importProvidersFrom, Component } from "@angular/core";
import { importProvidersFrom, Component, ChangeDetectionStrategy, signal } from "@angular/core";
import { RouterModule, Routes } from "@angular/router";
import {
Meta,
@@ -31,7 +31,6 @@ export default {
} as Meta;
const decorators = (options: {
components: any[];
routes: Routes;
applicationVersion?: string;
clientType?: ClientType;
@@ -56,7 +55,6 @@ const decorators = (options: {
},
),
moduleMetadata({
declarations: options.components,
imports: [RouterModule, ButtonModule],
providers: [
{
@@ -103,39 +101,31 @@ type Story = StoryObj<AnonLayoutWrapperComponent>;
// Default Example
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-default-primary-outlet-example-component",
template: "<p>Primary Outlet Example: <br> your primary component goes here</p>",
standalone: false,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DefaultPrimaryOutletExampleComponent {}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-default-secondary-outlet-example-component",
template: "<p>Secondary Outlet Example: <br> your secondary component goes here</p>",
standalone: false,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DefaultSecondaryOutletExampleComponent {}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-default-env-selector-outlet-example-component",
template: "<p>Env Selector Outlet Example: <br> your env selector component goes here</p>",
standalone: false,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DefaultEnvSelectorOutletExampleComponent {}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-header-actions-outlet-example-component",
template: "<p>Header Actions Outlet Example: <br> your header actions component goes here</p>",
standalone: false,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DefaultHeaderActionsOutletExampleComponent {}
@@ -145,11 +135,6 @@ export const DefaultContentExample: Story = {
template: "<router-outlet></router-outlet>",
}),
decorators: decorators({
components: [
DefaultPrimaryOutletExampleComponent,
DefaultSecondaryOutletExampleComponent,
DefaultEnvSelectorOutletExampleComponent,
],
routes: [
{
path: "**",
@@ -212,28 +197,27 @@ const changedData: AnonLayoutWrapperData = {
pageIcon: RegistrationCheckEmailIcon,
};
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "bit-dynamic-content-example-component",
template: `
<button type="button" bitButton buttonType="primary" (click)="toggleData()">Toggle Data</button>
`,
standalone: false,
imports: [ButtonModule],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class DynamicContentExampleComponent {
initialData = true;
private readonly initialData = signal(true);
constructor(private anonLayoutWrapperDataService: AnonLayoutWrapperDataService) {}
toggleData() {
if (this.initialData) {
if (this.initialData()) {
this.anonLayoutWrapperDataService.setAnonLayoutWrapperData(changedData);
} else {
this.anonLayoutWrapperDataService.setAnonLayoutWrapperData(initialData);
}
this.initialData = !this.initialData;
this.initialData.update((v) => !v);
}
}
@@ -243,7 +227,6 @@ export const DynamicContentExample: Story = {
template: "<router-outlet></router-outlet>",
}),
decorators: decorators({
components: [DynamicContentExampleComponent],
routes: [
{
path: "**",