bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 17:53:39 +00:00
Code Issues Releases Wiki Activity

[PM-8027] Inlin menu appears within input fields that do not relate to user login

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-05-10 10:57:32 -05:00
parent 70760080a2
commit c69be8493e
1 changed files with 58 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
apps/browser/src/autofill/services/autofill-field-qualification.service.ts
View File

@@ -4,41 +4,51 @@ import AutofillPageDetails from "../models/autofill-page-details";
import { AutoFillConstants } from "./autofill-constants";
export class AutofillFieldQualificationService {
autofillPageDetails: AutofillPageDetails;
private searchFieldNamesSet = new Set(AutoFillConstants.SearchFieldNames);
private excludedAutofillLoginTypesSet = new Set(AutoFillConstants.ExcludedAutofillLoginTypes);
private usernameFieldTypes = new Set(["text", "email", "tel"]);
private fieldIgnoreListString = AutoFillConstants.FieldIgnoreList.join(",");
private passwordFieldExcludeListString = AutoFillConstants.PasswordFieldExcludeList.join(",");
private autofillFieldKeywordsMap: WeakMap<AutofillField, string> = new WeakMap();
setAutofillPageDetails(autofillPageDetails: AutofillPageDetails): void {
this.autofillPageDetails = autofillPageDetails;
}
isLoginUsernameField(field: AutofillField): boolean {
isFieldForLoginForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean {
// Check if the field
return false;
}
isLoginPasswordField(field: AutofillField): boolean {
isUsernameField(field: AutofillField): boolean {
if (
field.type !== "password" ||
field.autoComplete === "new-password" ||
!this.usernameFieldTypes.has(field.type) ||
this.isExcludedFieldType(field, this.excludedAutofillLoginTypesSet)
) {
return false;
}
if (this.fieldHasDisqualifyingAttributeValue(field)) {
return this.keywordsFoundInFieldData(field, AutoFillConstants.UsernameFieldNames);
}
isExistingPasswordField(field: AutofillField): boolean {
if (field.autoComplete === "new-password") {
return false;
}
if (field.type === "password") {
return true;
return this.isPasswordField(field);
}
return this.isPseudoPasswordField(field);
isPasswordField(field: AutofillField): boolean {
const isInputPasswordType = field.type === "password";
if (
!isInputPasswordType ||
this.isExcludedFieldType(field, this.excludedAutofillLoginTypesSet) ||
this.fieldHasDisqualifyingAttributeValue(field)
) {
return false;
}
private isPseudoPasswordField(field: AutofillField): boolean {
return isInputPasswordType || this.isLikePasswordField(field);
}
private isLikePasswordField(field: AutofillField): boolean {
if (field.type !== "text") {
return false;
}
@@ -113,4 +123,36 @@ export class AutofillFieldQualificationService {
return false;
}
private keywordsFoundInFieldData(autofillFieldData: AutofillField, keywords: string[]) {
const searchedString = this.getAutofillFieldDataKeywords(autofillFieldData);
return keywords.some((keyword) => searchedString.includes(keyword));
}
private getAutofillFieldDataKeywords(autofillFieldData: AutofillField) {
if (this.autofillFieldKeywordsMap.has(autofillFieldData)) {
return this.autofillFieldKeywordsMap.get(autofillFieldData);
}
const keywordValues = [
autofillFieldData.htmlID,
autofillFieldData.htmlName,
autofillFieldData.htmlClass,
autofillFieldData.type,
autofillFieldData.title,
autofillFieldData.placeholder,
autofillFieldData.autoCompleteType,
autofillFieldData["label-data"],
autofillFieldData["label-aria"],
autofillFieldData["label-left"],
autofillFieldData["label-right"],
autofillFieldData["label-tag"],
autofillFieldData["label-top"],
]
.join(",")
.toLowerCase();
this.autofillFieldKeywordsMap.set(autofillFieldData, keywordValues);
return keywordValues;
}
}