bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-1796] The autofill keyboard shortcut does not prompt a user to unlock a locked extension within an incognito browsing session (#5337)

Browse Source 
* [PM-1796] The autofill keyboard shortcut does not prompt a user to unlock a locked extension within an incongito browsing session

* [PM-1796] Implementing fixes for how we handle focus redirection when logging a user in and attempting to autofill within the Firefox Workspaces addon

* [PM-1796] Removing the `openerTab` value from the createNewTab method within brwoserApi.ts

* [PM-1796] Removing async declaration from createNewTab

* [PM-1796] Removing unnecessary param from the call to openBitwardenExtrensionTab
This commit is contained in:
Cesar Gonzalez
2023-05-15 11:42:01 -05:00
committed by GitHub
parent 1eff0f776f
commit c7150b8981
2 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/background/runtime.background.ts
View File

@@ -75,6 +75,8 @@ export default class RuntimeBackground {
this.systemService.cancelProcessReload();
if (item) {
await BrowserApi.focusWindow(item.commandToRetry.sender.tab.windowId);
await BrowserApi.focusTab(item.commandToRetry.sender.tab.id);
await BrowserApi.tabSendMessageData(
item.commandToRetry.sender.tab,
"unlockCompleted",
@@ -103,7 +105,7 @@ export default class RuntimeBackground {
await this.main.openPopup();
break;
case "promptForLogin":
BrowserApi.openBitwardenExtensionTab("popup/index.html", true, sender.tab);
BrowserApi.openBitwardenExtensionTab("popup/index.html", true);
break;
case "openAddEditCipher": {
const addEditCipherUrl =
@@ -111,7 +113,7 @@ export default class RuntimeBackground {
? "popup/index.html#/edit-cipher"
: "popup/index.html#/edit-cipher?cipherId=" + msg.data.cipherId;
BrowserApi.openBitwardenExtensionTab(addEditCipherUrl, true, sender.tab);
BrowserApi.openBitwardenExtensionTab(addEditCipherUrl, true);
break;
}
case "closeTab":