From c7555127702135c77608c15c67ad6d49c0018b01 Mon Sep 17 00:00:00 2001 From: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com> Date: Thu, 25 Jul 2024 11:41:02 -0400 Subject: [PATCH] Auth/PM-10095 - Registration with Email Verification - Registration Finish - Fix endless load on Org Invite Accept (#10270) * PM-10095 - Properly center loading spinner * PM-10095 - RegistrationFinish - update query param changes subscription to have empty observable path for org invite to prevent observable error of switchmap receiving undefined. --- .../registration-finish/registration-finish.component.html | 2 +- .../registration-finish/registration-finish.component.ts | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/auth/src/angular/registration/registration-finish/registration-finish.component.html b/libs/auth/src/angular/registration/registration-finish/registration-finish.component.html index 70ca948f93d..e42ed91166a 100644 --- a/libs/auth/src/angular/registration/registration-finish/registration-finish.component.html +++ b/libs/auth/src/angular/registration/registration-finish/registration-finish.component.html @@ -1,4 +1,4 @@ -
+
diff --git a/libs/auth/src/angular/registration/registration-finish/registration-finish.component.ts b/libs/auth/src/angular/registration/registration-finish/registration-finish.component.ts index 580b339e1eb..03886fe88d6 100644 --- a/libs/auth/src/angular/registration/registration-finish/registration-finish.component.ts +++ b/libs/auth/src/angular/registration/registration-finish/registration-finish.component.ts @@ -1,7 +1,7 @@ import { CommonModule } from "@angular/common"; import { Component, OnDestroy, OnInit } from "@angular/core"; import { ActivatedRoute, Params, Router, RouterModule } from "@angular/router"; -import { Subject, from, switchMap, takeUntil, tap } from "rxjs"; +import { EMPTY, Subject, from, switchMap, takeUntil, tap } from "rxjs"; import { JslibModule } from "@bitwarden/angular/jslib.module"; import { MasterPasswordPolicyOptions } from "@bitwarden/common/admin-console/models/domain/master-password-policy-options"; @@ -76,6 +76,10 @@ export class RegistrationFinishComponent implements OnInit, OnDestroy { return from( this.registerVerificationEmailClicked(this.email, this.emailVerificationToken), ); + } else { + // org invite flow + this.loading = false; + return EMPTY; } }),