bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 00:03:56 +00:00
Code Issues Releases Wiki Activity

The domain of data URLs should be null. (#59)

Browse Source
This commit is contained in:
jgfaust
2020-01-25 07:52:51 -05:00
committed by Kyle Spearrin
parent 7d8143b288
commit c91ab626c2
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/common/misc/utils.spec.ts
View File

@@ -10,6 +10,10 @@ describe('Utils Service', () => {
expect(Utils.getDomain('bitwarden')).toBeNull(); expect(Utils.getDomain('bitwarden')).toBeNull();
}); });
it('should fail for data urls', () => {
expect(Utils.getDomain('data:image/jpeg;base64,AAA')).toBeNull();
});
it('should handle urls without protocol', () => { it('should handle urls without protocol', () => {
expect(Utils.getDomain('bitwarden.com')).toBe('bitwarden.com'); expect(Utils.getDomain('bitwarden.com')).toBe('bitwarden.com');
expect(Utils.getDomain('wrong://bitwarden.com')).toBe('bitwarden.com'); expect(Utils.getDomain('wrong://bitwarden.com')).toBe('bitwarden.com');

4
src/misc/utils.ts
View File

@@ -182,6 +182,10 @@ export class Utils {
return null; return null;
} }
if (uriString.startsWith('data:')) {
return null;
}
let httpUrl = uriString.startsWith('http://') || uriString.startsWith('https://'); let httpUrl = uriString.startsWith('http://') || uriString.startsWith('https://');
if (!httpUrl && uriString.indexOf('://') < 0 && Utils.tldEndingRegex.test(uriString)) { if (!httpUrl && uriString.indexOf('://') < 0 && Utils.tldEndingRegex.test(uriString)) {
uriString = 'http://' + uriString; uriString = 'http://' + uriString;