From c97e9373339d61c8f1bedd117459722179cff40c Mon Sep 17 00:00:00 2001
From: Andreas Coroiu <acoroiu@bitwarden.com>
Date: Wed, 22 Jan 2025 14:25:10 +0100
Subject: [PATCH] Fix sdk client undefined (#13003)

* feat: remove undefined from `client$`

* feat: add undefined to `userClient$`

* feat: implement TS strict for SdkService
---
 libs/common/src/platform/abstractions/sdk/sdk.service.ts | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/libs/common/src/platform/abstractions/sdk/sdk.service.ts b/libs/common/src/platform/abstractions/sdk/sdk.service.ts
index d44d38c36ab..78ec11c4022 100644
--- a/libs/common/src/platform/abstractions/sdk/sdk.service.ts
+++ b/libs/common/src/platform/abstractions/sdk/sdk.service.ts
@@ -1,5 +1,3 @@
-// FIXME: Update this file to be type safe and remove this and next line
-// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { BitwardenClient } from "@bitwarden/sdk-internal";
@@ -10,13 +8,13 @@ export abstract class SdkService {
   /**
    * Retrieve the version of the SDK.
    */
-  version$: Observable<string>;
+  abstract version$: Observable<string>;
 
   /**
    * Retrieve a client initialized without a user.
    * This client can only be used for operations that don't require a user context.
    */
-  client$: Observable<BitwardenClient | undefined>;
+  abstract client$: Observable<BitwardenClient>;
 
   /**
    * Retrieve a client initialized for a specific user.
@@ -29,5 +27,5 @@ export abstract class SdkService {
    *
    * @param userId
    */
-  abstract userClient$(userId: UserId): Observable<BitwardenClient>;
+  abstract userClient$(userId: UserId): Observable<BitwardenClient | undefined>;
 }