bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

[PM-2560] Fix Firefox default passkeys handling (#5690)

Browse Source 
* Return callback response in addListener

* Add clarifying comment

* Isolate returning the callback to fido2 commands

* Update apps/browser/src/platform/browser/browser-api.ts

Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>

* Fix formatting

---------

Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
This commit is contained in:
Robyn MacCallum
2023-07-10 16:29:10 -04:00
committed by GitHub
parent 50be33d650
commit ca5b033cfd
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/browser/src/platform/browser/browser-api.ts
View File

@@ -184,7 +184,18 @@ export class BrowserApi {
name: string, name: string,
callback: (message: any, sender: chrome.runtime.MessageSender, response: any) => unknown callback: (message: any, sender: chrome.runtime.MessageSender, response: any) => unknown
) { ) {
chrome.runtime.onMessage.addListener(callback); chrome.runtime.onMessage.addListener(
(msg: any, sender: chrome.runtime.MessageSender, sendResponse: any) => {
const messageResponse = callback(msg, sender, sendResponse);
if (!messageResponse) {
return false;
}
Promise.resolve(messageResponse);
return true;
}
);
// Keep track of all the events registered in a Safari popup so we can remove // Keep track of all the events registered in a Safari popup so we can remove
// them when the popup gets unloaded, otherwise we cause a memory leak // them when the popup gets unloaded, otherwise we cause a memory leak