bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 09:13:33 +00:00
Code Issues Releases Wiki Activity

Add eslint rule no-floating-promises (#7789)

Browse Source 
* add eslint rule no-floating-promises

* add eslint-disable comment to offending lines
This commit is contained in:
Will Martin
2024-02-02 15:13:37 -05:00
committed by GitHub
parent 6e96964c1a
commit cb8849c355
273 changed files with 1602 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/cli/src/platform/services/lowdb-storage.service.ts
View File

@@ -98,6 +98,8 @@ export class LowdbStorageService implements AbstractStorageService {
}
if (this.defaults != null) {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.lockDbFile(() => {
this.logService.info("Writing defaults.");
this.readForNoCache();
@@ -134,6 +136,8 @@ export class LowdbStorageService implements AbstractStorageService {
await this.waitForReady();
return this.lockDbFile(() => {
this.readForNoCache();
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.db.set(key, obj).write();
this.updatesSubject.next({ key, updateType: "save" });
this.logService.debug(`Successfully wrote ${key} to db`);
@@ -145,6 +149,8 @@ export class LowdbStorageService implements AbstractStorageService {
await this.waitForReady();
return this.lockDbFile(() => {
this.readForNoCache();
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.db.unset(key).write();
this.updatesSubject.next({ key, updateType: "remove" });
this.logService.debug(`Successfully removed ${key} from db`);
@@ -159,6 +165,8 @@ export class LowdbStorageService implements AbstractStorageService {
try {
return action();
} finally {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
release();
}
});