Add eslint rule no-floating-promises (#7789)

* add eslint rule no-floating-promises

* add eslint-disable comment to offending lines

apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.spec.ts

@@ -20,6 +20,8 @@ describe("ExposedPasswordsReportComponent", () => {
 
   beforeEach(() => {
     auditService = mock<AuditService>();
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.configureTestingModule({
       declarations: [ExposedPasswordsReportComponent, I18nPipe],
       providers: [

apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.spec.ts

@@ -18,6 +18,8 @@ describe("InactiveTwoFactorReportComponent", () => {
   let fixture: ComponentFixture<InactiveTwoFactorReportComponent>;
 
   beforeEach(() => {
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.configureTestingModule({
       declarations: [InactiveTwoFactorReportComponent, I18nPipe],
       providers: [

apps/web/src/app/tools/reports/pages/reused-passwords-report.component.spec.ts

@@ -17,6 +17,8 @@ describe("ReusedPasswordsReportComponent", () => {
   let fixture: ComponentFixture<ReusedPasswordsReportComponent>;
 
   beforeEach(() => {
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.configureTestingModule({
       declarations: [ReusedPasswordsReportComponent, I18nPipe],
       providers: [

apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.spec.ts

@@ -17,6 +17,8 @@ describe("UnsecuredWebsitesReportComponent", () => {
   let fixture: ComponentFixture<UnsecuredWebsitesReportComponent>;
 
   beforeEach(() => {
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.configureTestingModule({
       declarations: [UnsecuredWebsitesReportComponent, I18nPipe],
       providers: [

apps/web/src/app/tools/reports/pages/weak-passwords-report.component.spec.ts

@@ -20,6 +20,8 @@ describe("WeakPasswordsReportComponent", () => {
 
   beforeEach(() => {
     passwordStrengthService = mock<PasswordStrengthServiceAbstraction>();
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.configureTestingModule({
       declarations: [WeakPasswordsReportComponent, I18nPipe],
       providers: [

apps/web/src/app/tools/send/send.component.ts

@@ -76,6 +76,8 @@ export class SendComponent extends BaseSendComponent {
 
     // Broadcaster subscription - load if sync completes in the background
     this.broadcasterService.subscribe(BroadcasterSubscriptionId, (message: any) => {
+      // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       this.ngZone.run(async () => {
         switch (message.command) {
           case "syncCompleted":

apps/web/src/app/tools/vault-export/export.component.ts

@@ -82,6 +82,8 @@ export class ExportComponent extends BaseExportComponent {
       return;
     }
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     this.doExport();
   }