bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 08:43:33 +00:00
Code Issues Releases Wiki Activity

Add eslint rule no-floating-promises (#7789)

Browse Source 
* add eslint rule no-floating-promises

* add eslint-disable comment to offending lines
This commit is contained in:
Will Martin
2024-02-02 15:13:37 -05:00
committed by GitHub
parent 6e96964c1a
commit cb8849c355
273 changed files with 1602 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/web/src/connectors/captcha.ts
View File

@@ -9,6 +9,8 @@ if (window.location.pathname.includes("mobile")) {
}
document.addEventListener("DOMContentLoaded", () => {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
init();
});
@@ -75,6 +77,8 @@ async function start() {
callback: "captchaSuccess",
"error-callback": "captchaError",
});
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
watchHeight();
});
document.head.appendChild(script);
@@ -101,6 +105,8 @@ function onMessage() {
}
if (event.data === "start") {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
start();
}
},

2
apps/web/src/connectors/webauthn-fallback.ts
View File

@@ -106,6 +106,8 @@ function start() {
return;
}
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
initWebAuthn(json);
}