Add eslint rule no-floating-promises (#7789)

* add eslint rule no-floating-promises

* add eslint-disable comment to offending lines

libs/components/src/button/button.component.spec.ts

@@ -17,6 +17,8 @@ describe("Button", () => {
       declarations: [TestApp],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
     fixture = TestBed.createComponent(TestApp);
     testAppComponent = fixture.debugElement.componentInstance;

libs/components/src/dialog/directives/dialog-title-container.directive.ts

@@ -18,6 +18,8 @@ export class DialogTitleContainerDirective implements OnInit {
     // Based on angular/components, licensed under MIT
     // https://github.com/angular/components/blob/14.2.0/src/material/dialog/dialog-content-directives.ts#L121-L128
     if (this.dialogRef) {
+      // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       Promise.resolve().then(() => {
         const container = this.dialogRef.containerInstance as CdkDialogContainer;
 

libs/components/src/menu/menu.component.spec.ts

@@ -22,6 +22,8 @@ describe("Menu", () => {
       declarations: [TestApp],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
 
     fixture = TestBed.createComponent(TestApp);

libs/components/src/radio-button/radio-button.component.spec.ts

@@ -27,6 +27,8 @@ describe("RadioButton", () => {
       ],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
     fixture = TestBed.createComponent(TestApp);
     fixture.detectChanges();

libs/components/src/radio-button/radio-group.component.spec.ts

@@ -23,6 +23,8 @@ describe("RadioGroupComponent", () => {
       providers: [{ provide: I18nService, useValue: new I18nMockService({}) }],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
     fixture = TestBed.createComponent(TestApp);
     fixture.detectChanges();

libs/components/src/tabs/tab-group/tab-group.component.ts

@@ -106,6 +106,8 @@ export class TabGroupComponent
 
       // These values need to be updated after change detection as
       // the checked content may have references to them.
+      // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       Promise.resolve().then(() => {
         this.tabs.forEach((tab, index) => (tab.isActive = index === indexToSelect));
 

libs/components/src/toggle-group/toggle-group.component.spec.ts

@@ -17,6 +17,8 @@ describe("Button", () => {
       declarations: [TestApp],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
     fixture = TestBed.createComponent(TestApp);
     testAppComponent = fixture.debugElement.componentInstance;

libs/components/src/toggle-group/toggle.component.spec.ts

@@ -20,6 +20,8 @@ describe("Button", () => {
       providers: [{ provide: ToggleGroupComponent, useValue: mockGroupComponent }],
     });
 
+    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     TestBed.compileComponents();
     fixture = TestBed.createComponent(TestApp);
     testAppComponent = fixture.debugElement.componentInstance;