bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 22:33:35 +00:00
Code Issues Releases Wiki Activity

[PM-10259] improve forwarder rpc error handling (#10330)

Browse Source 
* only accept `application/json` responses
This commit is contained in:
✨ Audrey ✨
2024-07-30 15:39:49 -04:00
committed by GitHub
parent 18ef51449f
commit cbac5fde11
5 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/common/src/tools/integration/rpc/rest-client.ts
View File

@@ -48,7 +48,7 @@ export class RestClient {
const message = await this.tryGetErrorMessage(response);
const key = message ? "forwaderInvalidTokenWithMessage" : "forwaderInvalidToken";
return [key, message];
} else if (response.status === 429 || response.status >= 500) {
} else if (response.status >= 400) {
const message = await this.tryGetErrorMessage(response);
const key = message ? "forwarderError" : "forwarderUnknownError";
return [key, message];
@@ -59,6 +59,7 @@ export class RestClient {
const body = (await response.text()) ?? "";
// nullish continues processing; false returns undefined
// FIXME: inspect content-type header to determine extraction process
const error =
this.tryFindErrorAsJson(body) ?? this.tryFindErrorAsText(body) ?? response.statusText;