bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Code Issues Releases Wiki Activity

[PM-10107] evaluate the override password type policy (#10277)

Browse Source
This commit is contained in:
✨ Audrey ✨
2024-08-09 08:54:00 -04:00
committed by GitHub
parent 795c21a1c7
commit cbe7ae68cc
12 changed files with 84 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.spec.ts
View File

@@ -270,7 +270,7 @@ describe("LegacyPasswordGenerationService", () => {
const navigation = createNavigationGenerator(
{},
{
defaultType: "password",
overridePasswordType: "password",
},
);
const generator = new LegacyPasswordGenerationService(
@@ -284,7 +284,7 @@ describe("LegacyPasswordGenerationService", () => {
const [, policy] = await generator.getOptions();
expect(policy).toEqual({
defaultType: "password",
overridePasswordType: "password",
minLength: 20,
numberCount: 10,
specialCount: 11,
@@ -402,7 +402,7 @@ describe("LegacyPasswordGenerationService", () => {
const navigation = createNavigationGenerator(
{},
{
defaultType: "password",
overridePasswordType: "password",
},
);
const generator = new LegacyPasswordGenerationService(
@@ -416,7 +416,7 @@ describe("LegacyPasswordGenerationService", () => {
const [, policy] = await generator.enforcePasswordGeneratorPoliciesOnOptions({});
expect(policy).toEqual({
defaultType: "password",
overridePasswordType: "password",
minLength: 20,
numberCount: 10,
specialCount: 11,

2
libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.ts
View File

@@ -248,7 +248,7 @@ export class LegacyPasswordGenerationService implements PasswordGenerationServic
...options,
...navigationEvaluator.sanitize(navigationApplied),
};
if (options.type === "password") {
if (navigationSanitized.type === "password") {
const applied = passwordEvaluator.applyPolicy(navigationSanitized);
const sanitized = passwordEvaluator.sanitize(applied);
return [sanitized, policy];