bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 22:03:36 +00:00
Code Issues Releases Wiki Activity

[PM-12561] - add data attrs for send form (#11209)

Browse Source 
* add data attrs for send form

* Add data-testid for toggle view password

* Revert "Add data-testid for toggle view password"

This reverts commit bd6fcc8c1b.

* move dataid to component

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Jordan Aasen
2024-09-25 05:03:42 -07:00
committed by GitHub
parent d587be1831
commit cd9045483b
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libs/tools/send/send-ui/src/send-form/components/options/send-options.component.html
View File

@@ -15,12 +15,19 @@
<bit-label *ngIf="!hasPassword">{{ "password" | i18n }}</bit-label> <bit-label *ngIf="!hasPassword">{{ "password" | i18n }}</bit-label>
<bit-label *ngIf="hasPassword">{{ "newPassword" | i18n }}</bit-label> <bit-label *ngIf="hasPassword">{{ "newPassword" | i18n }}</bit-label>
<input bitInput type="password" formControlName="password" /> <input bitInput type="password" formControlName="password" />
<button type="button" bitIconButton bitSuffix bitPasswordInputToggle></button> <button
data-testid="toggle-visibility-for-password"
type="button"
bitIconButton
bitSuffix
bitPasswordInputToggle
></button>
<button <button
type="button" type="button"
bitIconButton="bwi-generate" bitIconButton="bwi-generate"
bitSuffix bitSuffix
[appA11yTitle]="'generatePassword' | i18n" [appA11yTitle]="'generatePassword' | i18n"
data-testid="generate-password"
></button> ></button>
<bit-hint>{{ "sendPasswordDescV2" | i18n }}</bit-hint> <bit-hint>{{ "sendPasswordDescV2" | i18n }}</bit-hint>
</bit-form-field> </bit-form-field>

2
libs/tools/send/send-ui/src/send-form/components/send-details/send-details.component.html
View File

@@ -23,7 +23,7 @@
<bit-form-field *ngIf="sendLink"> <bit-form-field *ngIf="sendLink">
<bit-label>{{ "sendLink" | i18n }}</bit-label> <bit-label>{{ "sendLink" | i18n }}</bit-label>
<input bitInput type="text" [value]="sendLink" readonly /> <input data-testid="send-link" bitInput type="text" [value]="sendLink" readonly />
<button <button
type="button" type="button"
bitSuffix bitSuffix

4
libs/tools/send/send-ui/src/send-form/components/send-details/send-file-details.component.html
View File

@@ -1,8 +1,8 @@
<bit-section [formGroup]="sendFileDetailsForm"> <bit-section [formGroup]="sendFileDetailsForm">
<div *ngIf="config.mode === 'edit'"> <div *ngIf="config.mode === 'edit'">
<div bitTypography="body2" class="tw-text-muted">{{ "file" | i18n }}</div> <div bitTypography="body2" class="tw-text-muted">{{ "file" | i18n }}</div>
<div>{{ originalSendView.file.fileName }}</div> <div data-testid="file-name">{{ originalSendView.file.fileName }}</div>
<div class="tw-text-muted">{{ originalSendView.file.sizeName }}</div> <div data-testid="file-size" class="tw-text-muted">{{ originalSendView.file.sizeName }}</div>
</div> </div>
<bit-form-field *ngIf="config.mode !== 'edit'"> <bit-form-field *ngIf="config.mode !== 'edit'">
<bit-label for="file">{{ "fileToShare" | i18n }}</bit-label> <bit-label for="file">{{ "fileToShare" | i18n }}</bit-label>