From cef6a5e8d0301d8234039cec1538553168b5b2ca Mon Sep 17 00:00:00 2001 From: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com> Date: Thu, 3 Jul 2025 04:49:39 -0400 Subject: [PATCH] [SM-1273] Adding enums for additional event logs for secrets (#15274) * Adding enums for additional event logs for secrets * updating messages * Updating messages to be consistent for logs --- apps/web/src/app/core/event.service.ts | 16 ++++++++-- apps/web/src/locales/en/messages.json | 38 +++++++++++++++++++++++- libs/common/src/enums/event-type.enum.ts | 3 ++ 3 files changed, 54 insertions(+), 3 deletions(-) diff --git a/apps/web/src/app/core/event.service.ts b/apps/web/src/app/core/event.service.ts index d6e5c8eba5f..14c87181f62 100644 --- a/apps/web/src/app/core/event.service.ts +++ b/apps/web/src/app/core/event.service.ts @@ -467,8 +467,20 @@ export class EventService { break; // Secrets Manager case EventType.Secret_Retrieved: - msg = this.i18nService.t("accessedSecret", this.formatSecretId(ev)); - humanReadableMsg = this.i18nService.t("accessedSecret", this.getShortId(ev.secretId)); + msg = this.i18nService.t("accessedSecretWithId", this.formatSecretId(ev)); + humanReadableMsg = this.i18nService.t("accessedSecretWithId", this.getShortId(ev.secretId)); + break; + case EventType.Secret_Created: + msg = this.i18nService.t("createdSecretWithId", this.formatSecretId(ev)); + humanReadableMsg = this.i18nService.t("createdSecretWithId", this.getShortId(ev.secretId)); + break; + case EventType.Secret_Deleted: + msg = this.i18nService.t("deletedSecretWithId", this.formatSecretId(ev)); + humanReadableMsg = this.i18nService.t("deletedSecretWithId", this.getShortId(ev.secretId)); + break; + case EventType.Secret_Edited: + msg = this.i18nService.t("editedSecretWithId", this.formatSecretId(ev)); + humanReadableMsg = this.i18nService.t("editedSecretWithId", this.getShortId(ev.secretId)); break; default: break; diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json index eed2757eacc..76dcf2cb97d 100644 --- a/apps/web/src/locales/en/messages.json +++ b/apps/web/src/locales/en/messages.json @@ -8237,8 +8237,44 @@ "errorReadingImportFile": { "message": "An error occurred when trying to read the import file" }, + "accessedSecretWithId": { + "message": "Accessed a secret with identifier: $SECRET_ID$", + "placeholders": { + "secret_id": { + "content": "$1", + "example": "4d34e8a8" + } + } + }, "accessedSecret": { - "message": "Accessed secret $SECRET_ID$.", + "message": "Accessed secret $SECRET_ID$.", + "placeholders": { + "secret_id": { + "content": "$1", + "example": "4d34e8a8" + } + } + }, + "editedSecretWithId": { + "message": "Edited a secret with identifier: $SECRET_ID$", + "placeholders": { + "secret_id": { + "content": "$1", + "example": "4d34e8a8" + } + } + }, + "deletedSecretWithId": { + "message": "Deleted a secret with identifier: $SECRET_ID$", + "placeholders": { + "secret_id": { + "content": "$1", + "example": "4d34e8a8" + } + } + }, + "createdSecretWithId": { + "message": "Created a new secret with identifier: $SECRET_ID$", "placeholders": { "secret_id": { "content": "$1", diff --git a/libs/common/src/enums/event-type.enum.ts b/libs/common/src/enums/event-type.enum.ts index 9efe49b1b0f..914dac00abb 100644 --- a/libs/common/src/enums/event-type.enum.ts +++ b/libs/common/src/enums/event-type.enum.ts @@ -90,4 +90,7 @@ export enum EventType { OrganizationDomain_NotVerified = 2003, Secret_Retrieved = 2100, + Secret_Created = 2101, + Secret_Edited = 2102, + Secret_Deleted = 2103, }