bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-14 15:23:33 +00:00
Code Issues Releases Wiki Activity

[PM-4349] Migrate hasPremium and debounceNavigation to be functional (#6591)

Browse Source 
Class based router guards are deprecated as of Angular 15.2, per angular.io/guide/deprecations#router-class-and-injection-token-guards. To simplify future angular upgrades we need to resolve these deprecations.

This PR migrates the HasPremium and DebounceNavigationService guards to use the new functional pattern.
This commit is contained in:
Oscar Hinton
2023-12-11 15:22:34 +01:00
committed by GitHub
parent 7db844baf2
commit cf0c6e8896
6 changed files with 48 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/popup/app-routing.module.ts
View File

@@ -47,7 +47,7 @@ import { VaultItemsComponent } from "../vault/popup/components/vault/vault-items
import { ViewComponent } from "../vault/popup/components/vault/view.component";
import { FolderAddEditComponent } from "../vault/popup/settings/folder-add-edit.component";
import { DebounceNavigationService } from "./services/debounceNavigationService";
import { debounceNavigationGuard } from "./services/debounce-navigation.service";
import { ExcludedDomainsComponent } from "./settings/excluded-domains.component";
import { FoldersComponent } from "./settings/folders.component";
import { HelpAndFeedbackComponent } from "./settings/help-and-feedback.component";
@@ -183,14 +183,14 @@ const routes: Routes = [
{
path: "add-cipher",
component: AddEditComponent,
canActivate: [AuthGuard, DebounceNavigationService],
canActivate: [AuthGuard, debounceNavigationGuard()],
data: { state: "add-cipher" },
runGuardsAndResolvers: "always",
},
{
path: "edit-cipher",
component: AddEditComponent,
canActivate: [AuthGuard, DebounceNavigationService],
canActivate: [AuthGuard, debounceNavigationGuard()],
data: { state: "edit-cipher" },
runGuardsAndResolvers: "always",
},