From 53e69e6dc6a05435730d59770ef28167f26a3f93 Mon Sep 17 00:00:00 2001 From: Jonathan Prusik Date: Mon, 26 Aug 2024 10:03:32 -0400 Subject: [PATCH 1/4] [PM-9673] Autofocus newly added input in the excluded domains view (#10641) * autofocus newly added input in the excluded domains view * update subscription --- .../popup/settings/autofill.component.ts | 22 +++++++++---------- .../settings/excluded-domains.component.html | 1 + .../settings/excluded-domains.component.ts | 20 +++++++++++++++-- 3 files changed, 30 insertions(+), 13 deletions(-) diff --git a/apps/browser/src/autofill/popup/settings/autofill.component.ts b/apps/browser/src/autofill/popup/settings/autofill.component.ts index dc6a4a0880e..a03a37a5d0a 100644 --- a/apps/browser/src/autofill/popup/settings/autofill.component.ts +++ b/apps/browser/src/autofill/popup/settings/autofill.component.ts @@ -78,8 +78,8 @@ export class AutofillComponent implements OnInit { * Default values set here are used in component state operations * until corresponding stored settings have loaded on init. */ - protected canOverrideBrowserAutofillSetting = false; - protected defaultBrowserAutofillDisabled = false; + protected canOverrideBrowserAutofillSetting: boolean = false; + protected defaultBrowserAutofillDisabled: boolean = false; protected inlineMenuVisibility: InlineMenuVisibilitySetting = AutofillOverlayVisibility.OnFieldFocus; protected browserClientVendor: BrowserClientVendor = BrowserClientVendors.Unknown; @@ -90,21 +90,21 @@ export class AutofillComponent implements OnInit { protected autofillOnPageLoadFromPolicy$ = this.autofillSettingsService.activateAutofillOnPageLoadFromPolicy$; - enableAutofillOnPageLoad = false; - enableInlineMenu = false; - enableInlineMenuOnIconSelect = false; - autofillOnPageLoadDefault = false; + enableAutofillOnPageLoad: boolean = false; + enableInlineMenu: boolean = false; + enableInlineMenuOnIconSelect: boolean = false; + autofillOnPageLoadDefault: boolean = false; autofillOnPageLoadOptions: { name: string; value: boolean }[]; - enableContextMenuItem = false; - enableAutoTotpCopy = false; + enableContextMenuItem: boolean = false; + enableAutoTotpCopy: boolean = false; clearClipboard: ClearClipboardDelaySetting; clearClipboardOptions: { name: string; value: ClearClipboardDelaySetting }[]; defaultUriMatch: UriMatchStrategySetting = UriMatchStrategy.Domain; uriMatchOptions: { name: string; value: UriMatchStrategySetting }[]; - showCardsCurrentTab = true; - showIdentitiesCurrentTab = true; + showCardsCurrentTab: boolean = true; + showIdentitiesCurrentTab: boolean = true; autofillKeyboardHelperText: string; - accountSwitcherEnabled = false; + accountSwitcherEnabled: boolean = false; constructor( private i18nService: I18nService, diff --git a/apps/browser/src/autofill/popup/settings/excluded-domains.component.html b/apps/browser/src/autofill/popup/settings/excluded-domains.component.html index d3c76a653e2..62d8bc59970 100644 --- a/apps/browser/src/autofill/popup/settings/excluded-domains.component.html +++ b/apps/browser/src/autofill/popup/settings/excluded-domains.component.html @@ -27,6 +27,7 @@ }} >; + accountSwitcherEnabled = false; dataIsPristine = true; excludedDomainsState: string[] = []; @@ -63,6 +65,8 @@ export class ExcludedDomainsComponent implements OnInit, OnDestroy { // How many fields should be non-editable before editable fields fieldsEditThreshold: number = 0; + private destroy$ = new Subject(); + constructor( private domainSettingsService: DomainSettingsService, private i18nService: I18nService, @@ -84,10 +88,22 @@ export class ExcludedDomainsComponent implements OnInit, OnDestroy { // Do not allow the first x (pre-existing) fields to be edited this.fieldsEditThreshold = this.storedExcludedDomains.length; + + this.uriInputElements.changes.pipe(takeUntil(this.destroy$)).subscribe(({ last }) => { + this.focusNewUriInput(last); + }); } ngOnDestroy() { this.broadcasterService.unsubscribe(BroadcasterSubscriptionId); + this.destroy$.next(); + this.destroy$.complete(); + } + + focusNewUriInput(elementRef: ElementRef) { + if (elementRef?.nativeElement) { + elementRef.nativeElement.focus(); + } } async addNewDomain() { From f7c4a82773b60975f2facd763b9ec62ae93f8a4d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 26 Aug 2024 11:37:33 -0400 Subject: [PATCH 2/4] [deps] DevOps: Update docker/build-push-action action to v6 (#10597) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .github/workflows/build-web.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-web.yml b/.github/workflows/build-web.yml index 8576fb6760a..c93a61e8a2d 100644 --- a/.github/workflows/build-web.yml +++ b/.github/workflows/build-web.yml @@ -234,7 +234,7 @@ jobs: run: echo "name=$_AZ_REGISTRY/${PROJECT_NAME}:${IMAGE_TAG}" >> $GITHUB_OUTPUT - name: Build Docker image - uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56 # v5.1.0 + uses: docker/build-push-action@5cd11c3a4ced054e52742c5fd54dca954e0edd85 # v6.7.0 with: context: apps/web file: apps/web/Dockerfile From b0636bb39d9c231e4047f6b458017def3128f2e0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 26 Aug 2024 11:38:10 -0400 Subject: [PATCH 3/4] [deps] DevOps: Update crowdin/github-action action to v2 (#10596) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .github/workflows/build-browser.yml | 2 +- .github/workflows/build-desktop.yml | 2 +- .github/workflows/build-web.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-browser.yml b/.github/workflows/build-browser.yml index 3c99f610cec..a8660bad182 100644 --- a/.github/workflows/build-browser.yml +++ b/.github/workflows/build-browser.yml @@ -382,7 +382,7 @@ jobs: secrets: "crowdin-api-token" - name: Upload Sources - uses: crowdin/github-action@c953b17499daa6be3e5afbf7a63616fb02d8b18d # v1.19.0 + uses: crowdin/github-action@6ed209d411599a981ccb978df3be9dc9b8a81699 # v2.1.1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} CROWDIN_API_TOKEN: ${{ steps.retrieve-secrets.outputs.crowdin-api-token }} diff --git a/.github/workflows/build-desktop.yml b/.github/workflows/build-desktop.yml index a8ee1091a24..c933ea304c6 100644 --- a/.github/workflows/build-desktop.yml +++ b/.github/workflows/build-desktop.yml @@ -1248,7 +1248,7 @@ jobs: secrets: "crowdin-api-token" - name: Upload Sources - uses: crowdin/github-action@c953b17499daa6be3e5afbf7a63616fb02d8b18d # v1.19.0 + uses: crowdin/github-action@6ed209d411599a981ccb978df3be9dc9b8a81699 # v2.1.1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} CROWDIN_API_TOKEN: ${{ steps.retrieve-secrets.outputs.crowdin-api-token }} diff --git a/.github/workflows/build-web.yml b/.github/workflows/build-web.yml index c93a61e8a2d..46e65e8924b 100644 --- a/.github/workflows/build-web.yml +++ b/.github/workflows/build-web.yml @@ -270,7 +270,7 @@ jobs: secrets: "crowdin-api-token" - name: Upload Sources - uses: crowdin/github-action@c953b17499daa6be3e5afbf7a63616fb02d8b18d # v1.19.0 + uses: crowdin/github-action@6ed209d411599a981ccb978df3be9dc9b8a81699 # v2.1.1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} CROWDIN_API_TOKEN: ${{ steps.retrieve-secrets.outputs.crowdin-api-token }} From 991155d3a5b91f1ca56eb8dfc1b1443ee5dae095 Mon Sep 17 00:00:00 2001 From: Victoria League Date: Mon, 26 Aug 2024 11:43:03 -0400 Subject: [PATCH 4/4] [CL-318] Ensure item content truncates when the 'start' slot is populated (#10727) --- libs/components/src/item/item-content.component.html | 2 +- libs/components/src/item/item.stories.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/components/src/item/item-content.component.html b/libs/components/src/item/item-content.component.html index da69c79c1eb..da45c8b3b61 100644 --- a/libs/components/src/item/item-content.component.html +++ b/libs/components/src/item/item-content.component.html @@ -1,7 +1,7 @@
-
+
diff --git a/libs/components/src/item/item.stories.ts b/libs/components/src/item/item.stories.ts index 5198d7efa62..e8accfd6933 100644 --- a/libs/components/src/item/item.stories.ts +++ b/libs/components/src/item/item.stories.ts @@ -115,6 +115,7 @@ export const TextOverflow: Story = { template: /*html*/ ` + Helloooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo! Worlddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd!