1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-14 07:13:32 +00:00

Reports remove unneeded dependency on stateService (#4426)

This commit is contained in:
Daniel James Smith
2023-01-11 17:33:00 +01:00
committed by GitHub
parent fa13cab220
commit d138cb90ab
10 changed files with 8 additions and 41 deletions

View File

@@ -7,7 +7,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction"; import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { Cipher } from "@bitwarden/common/models/domain/cipher"; import { Cipher } from "@bitwarden/common/models/domain/cipher";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -27,19 +26,11 @@ export class ExposedPasswordsReportComponent extends BaseExposedPasswordsReportC
auditService: AuditService, auditService: AuditService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
private organizationService: OrganizationService, private organizationService: OrganizationService,
private route: ActivatedRoute, private route: ActivatedRoute,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super( super(cipherService, auditService, modalService, messagingService, passwordRepromptService);
cipherService,
auditService,
modalService,
messagingService,
stateService,
passwordRepromptService
);
} }
ngOnInit() { ngOnInit() {

View File

@@ -7,7 +7,6 @@ import { LogService } from "@bitwarden/common/abstractions/log.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction"; import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
// eslint-disable-next-line no-restricted-imports // eslint-disable-next-line no-restricted-imports
@@ -23,20 +22,12 @@ export class InactiveTwoFactorReportComponent extends BaseInactiveTwoFactorRepor
cipherService: CipherService, cipherService: CipherService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute, private route: ActivatedRoute,
logService: LogService, logService: LogService,
passwordRepromptService: PasswordRepromptService, passwordRepromptService: PasswordRepromptService,
private organizationService: OrganizationService private organizationService: OrganizationService
) { ) {
super( super(cipherService, modalService, messagingService, logService, passwordRepromptService);
cipherService,
modalService,
messagingService,
stateService,
logService,
passwordRepromptService
);
} }
async ngOnInit() { async ngOnInit() {

View File

@@ -6,7 +6,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction"; import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
// eslint-disable-next-line no-restricted-imports // eslint-disable-next-line no-restricted-imports
@@ -22,12 +21,11 @@ export class UnsecuredWebsitesReportComponent extends BaseUnsecuredWebsitesRepor
cipherService: CipherService, cipherService: CipherService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute, private route: ActivatedRoute,
private organizationService: OrganizationService, private organizationService: OrganizationService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(cipherService, modalService, messagingService, stateService, passwordRepromptService); super(cipherService, modalService, messagingService, passwordRepromptService);
} }
async ngOnInit() { async ngOnInit() {

View File

@@ -7,7 +7,6 @@ import { MessagingService } from "@bitwarden/common/abstractions/messaging.servi
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction"; import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service"; import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { Cipher } from "@bitwarden/common/models/domain/cipher"; import { Cipher } from "@bitwarden/common/models/domain/cipher";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -27,7 +26,6 @@ export class WeakPasswordsReportComponent extends BaseWeakPasswordsReportCompone
passwordGenerationService: PasswordGenerationService, passwordGenerationService: PasswordGenerationService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute, private route: ActivatedRoute,
private organizationService: OrganizationService, private organizationService: OrganizationService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
@@ -37,7 +35,6 @@ export class WeakPasswordsReportComponent extends BaseWeakPasswordsReportCompone
passwordGenerationService, passwordGenerationService,
modalService, modalService,
messagingService, messagingService,
stateService,
passwordRepromptService passwordRepromptService
); );
} }

View File

@@ -3,7 +3,6 @@ import { Directive, ViewChild, ViewContainerRef } from "@angular/core";
import { ModalService } from "@bitwarden/angular/services/modal.service"; import { ModalService } from "@bitwarden/angular/services/modal.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherRepromptType } from "@bitwarden/common/enums/cipherRepromptType"; import { CipherRepromptType } from "@bitwarden/common/enums/cipherRepromptType";
import { Organization } from "@bitwarden/common/models/domain/organization"; import { Organization } from "@bitwarden/common/models/domain/organization";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -25,7 +24,6 @@ export class CipherReportComponent {
private modalService: ModalService, private modalService: ModalService,
protected messagingService: MessagingService, protected messagingService: MessagingService,
public requiresPaid: boolean, public requiresPaid: boolean,
private stateService: StateService,
protected passwordRepromptService: PasswordRepromptService protected passwordRepromptService: PasswordRepromptService
) {} ) {}

View File

@@ -5,7 +5,6 @@ import { AuditService } from "@bitwarden/common/abstractions/audit.service";
import { CipherService } from "@bitwarden/common/abstractions/cipher.service"; import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType"; import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -23,10 +22,9 @@ export class ExposedPasswordsReportComponent extends CipherReportComponent imple
protected auditService: AuditService, protected auditService: AuditService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(modalService, messagingService, true, stateService, passwordRepromptService); super(modalService, messagingService, true, passwordRepromptService);
} }
ngOnInit() { ngOnInit() {

View File

@@ -5,7 +5,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { LogService } from "@bitwarden/common/abstractions/log.service"; import { LogService } from "@bitwarden/common/abstractions/log.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType"; import { CipherType } from "@bitwarden/common/enums/cipherType";
import { Utils } from "@bitwarden/common/misc/utils"; import { Utils } from "@bitwarden/common/misc/utils";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -24,11 +23,10 @@ export class InactiveTwoFactorReportComponent extends CipherReportComponent impl
protected cipherService: CipherService, protected cipherService: CipherService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
private logService: LogService, private logService: LogService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(modalService, messagingService, true, stateService, passwordRepromptService); super(modalService, messagingService, true, passwordRepromptService);
} }
async ngOnInit() { async ngOnInit() {

View File

@@ -24,7 +24,7 @@ export class ReusedPasswordsReportComponent extends CipherReportComponent implem
stateService: StateService, stateService: StateService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(modalService, messagingService, true, stateService, passwordRepromptService); super(modalService, messagingService, true, passwordRepromptService);
} }
async ngOnInit() { async ngOnInit() {

View File

@@ -4,7 +4,6 @@ import { ModalService } from "@bitwarden/angular/services/modal.service";
import { CipherService } from "@bitwarden/common/abstractions/cipher.service"; import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType"; import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@@ -19,10 +18,9 @@ export class UnsecuredWebsitesReportComponent extends CipherReportComponent impl
protected cipherService: CipherService, protected cipherService: CipherService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(modalService, messagingService, true, stateService, passwordRepromptService); super(modalService, messagingService, true, passwordRepromptService);
} }
async ngOnInit() { async ngOnInit() {

View File

@@ -5,7 +5,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service"; import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service"; import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service"; import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType"; import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view"; import { CipherView } from "@bitwarden/common/models/view/cipher.view";
import { BadgeTypes } from "@bitwarden/components"; import { BadgeTypes } from "@bitwarden/components";
@@ -26,10 +25,9 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
protected passwordGenerationService: PasswordGenerationService, protected passwordGenerationService: PasswordGenerationService,
modalService: ModalService, modalService: ModalService,
messagingService: MessagingService, messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService passwordRepromptService: PasswordRepromptService
) { ) {
super(modalService, messagingService, true, stateService, passwordRepromptService); super(modalService, messagingService, true, passwordRepromptService);
} }
async ngOnInit() { async ngOnInit() {