bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 05:43:41 +00:00
Code Issues Releases Wiki Activity

Revert "PM-21553: Added support for credential.toJSON() (#14734)" (#14819)

Browse Source 
This reverts commit df8d184889.
This commit is contained in:
Anders Åberg
2025-05-16 19:30:47 +02:00
committed by GitHub
parent 27042e8023
commit d16a5cb73e
2 changed files with 0 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/fido2/utils/webauthn-utils.ts
View File

@@ -88,7 +88,6 @@ export class WebauthnUtils {
getClientExtensionResults: () => ({ getClientExtensionResults: () => ({
credProps: result.extensions.credProps, credProps: result.extensions.credProps,
}), }),
toJSON: () => Fido2Utils.createResultToJson(result),
} as PublicKeyCredential; } as PublicKeyCredential;
// Modify prototype chains to fix `instanceof` calls. // Modify prototype chains to fix `instanceof` calls.
@@ -135,7 +134,6 @@ export class WebauthnUtils {
} as AuthenticatorAssertionResponse, } as AuthenticatorAssertionResponse,
getClientExtensionResults: () => ({}), getClientExtensionResults: () => ({}),
authenticatorAttachment: "platform", authenticatorAttachment: "platform",
toJSON: () => Fido2Utils.getResultToJson(result),
} as PublicKeyCredential; } as PublicKeyCredential;
// Modify prototype chains to fix `instanceof` calls. // Modify prototype chains to fix `instanceof` calls.

39
libs/common/src/platform/services/fido2/fido2-utils.ts
View File

@@ -1,45 +1,6 @@
// FIXME: Update this file to be type safe and remove this and next line // FIXME: Update this file to be type safe and remove this and next line
import type {
AssertCredentialResult,
CreateCredentialResult,
} from "../../abstractions/fido2/fido2-client.service.abstraction";
// @ts-strict-ignore // @ts-strict-ignore
export class Fido2Utils { export class Fido2Utils {
static createResultToJson(result: CreateCredentialResult): any {
return {
id: result.credentialId,
rawId: result.credentialId,
response: {
clientDataJSON: result.clientDataJSON,
authenticatorData: result.authData,
transports: result.transports,
publicKey: result.publicKey,
publicKeyAlgorithm: result.publicKeyAlgorithm,
attestationObject: result.attestationObject,
},
authenticatorAttachment: "platform",
clientExtensionResults: result.extensions,
type: "public-key",
};
}
static getResultToJson(result: AssertCredentialResult): any {
return {
id: result.credentialId,
rawId: result.credentialId,
response: {
clientDataJSON: result.clientDataJSON,
authenticatorData: result.authenticatorData,
signature: result.signature,
userHandle: result.userHandle,
},
authenticatorAttachment: "platform",
clientExtensionResults: {},
type: "public-key",
};
}
static bufferToString(bufferSource: BufferSource): string { static bufferToString(bufferSource: BufferSource): string {
return Fido2Utils.fromBufferToB64(Fido2Utils.bufferSourceToUint8Array(bufferSource)) return Fido2Utils.fromBufferToB64(Fido2Utils.bufferSourceToUint8Array(bufferSource))
.replace(/\+/g, "-") .replace(/\+/g, "-")