bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 06:43:35 +00:00
Code Issues Releases Wiki Activity

Added type declarations where chrome.tabs.Tab applies

Browse Source
This commit is contained in:
Daniel James Smith
2021-10-15 19:42:05 +02:00
parent f951c860ea
commit d1977f1f08
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/background/notification.background.ts
View File

@@ -91,7 +91,7 @@ export default class NotificationBackground {
} }
} }
async checkNotificationQueue(tab: any = null): Promise<any> { async checkNotificationQueue(tab: chrome.tabs.Tab = null): Promise<void> {
if (this.notificationQueue.length === 0) { if (this.notificationQueue.length === 0) {
return; return;
} }
@@ -116,7 +116,7 @@ export default class NotificationBackground {
setTimeout(() => this.cleanupNotificationQueue(), 2 * 60 * 1000); // check every 2 minutes setTimeout(() => this.cleanupNotificationQueue(), 2 * 60 * 1000); // check every 2 minutes
} }
private doNotificationQueueCheck(tab: any) { private doNotificationQueueCheck(tab: chrome.tabs.Tab): void {
if (tab == null) { if (tab == null) {
return; return;
} }
@@ -150,7 +150,7 @@ export default class NotificationBackground {
} }
} }
private removeTabFromNotificationQueue(tab: any) { private removeTabFromNotificationQueue(tab: chrome.tabs.Tab) {
for (let i = this.notificationQueue.length - 1; i >= 0; i--) { for (let i = this.notificationQueue.length - 1; i >= 0; i--) {
if (this.notificationQueue[i].tabId === tab.id) { if (this.notificationQueue[i].tabId === tab.id) {
this.notificationQueue.splice(i, 1); this.notificationQueue.splice(i, 1);
@@ -158,7 +158,7 @@ export default class NotificationBackground {
} }
} }
private async addLogin(loginInfo: any, tab: any) { private async addLogin(loginInfo: any, tab: chrome.tabs.Tab) {
const loginDomain = Utils.getDomain(loginInfo.url); const loginDomain = Utils.getDomain(loginInfo.url);
if (loginDomain == null) { if (loginDomain == null) {
return; return;
@@ -200,7 +200,7 @@ export default class NotificationBackground {
} }
} }
private async pushAddLoginToQueue(loginDomain: string, loginInfo: any, tab: any, isVaultLocked: boolean = false) { private async pushAddLoginToQueue(loginDomain: string, loginInfo: any, tab: chrome.tabs.Tab, isVaultLocked: boolean = false) {
// remove any old messages for this tab // remove any old messages for this tab
this.removeTabFromNotificationQueue(tab); this.removeTabFromNotificationQueue(tab);
const message: AddLoginQueueMessage = { const message: AddLoginQueueMessage = {
@@ -217,7 +217,7 @@ export default class NotificationBackground {
await this.checkNotificationQueue(tab); await this.checkNotificationQueue(tab);
} }
private async changedPassword(changeData: any, tab: any) { private async changedPassword(changeData: any, tab: chrome.tabs.Tab) {
const loginDomain = Utils.getDomain(changeData.url); const loginDomain = Utils.getDomain(changeData.url);
if (loginDomain == null) { if (loginDomain == null) {
return; return;
@@ -243,7 +243,7 @@ export default class NotificationBackground {
} }
} }
private async pushChangePasswordToQueue(cipherId: string, loginDomain: string, newPassword: string, tab: any, isVaultLocked: boolean = false) { private async pushChangePasswordToQueue(cipherId: string, loginDomain: string, newPassword: string, tab: chrome.tabs.Tab, isVaultLocked: boolean = false) {
// remove any old messages for this tab // remove any old messages for this tab
this.removeTabFromNotificationQueue(tab); this.removeTabFromNotificationQueue(tab);
const message: AddChangePasswordQueueMessage = { const message: AddChangePasswordQueueMessage = {
@@ -259,7 +259,7 @@ export default class NotificationBackground {
await this.checkNotificationQueue(tab); await this.checkNotificationQueue(tab);
} }
private async saveOrUpdateCredentials(tab: any, folderId?: string) { private async saveOrUpdateCredentials(tab: chrome.tabs.Tab, folderId?: string) {
for (let i = this.notificationQueue.length - 1; i >= 0; i--) { for (let i = this.notificationQueue.length - 1; i >= 0; i--) {
const queueMessage = this.notificationQueue[i]; const queueMessage = this.notificationQueue[i];
if (queueMessage.tabId !== tab.id || if (queueMessage.tabId !== tab.id ||
@@ -346,7 +346,7 @@ export default class NotificationBackground {
} }
} }
private async saveNever(tab: any) { private async saveNever(tab: chrome.tabs.Tab) {
for (let i = this.notificationQueue.length - 1; i >= 0; i--) { for (let i = this.notificationQueue.length - 1; i >= 0; i--) {
const queueMessage = this.notificationQueue[i]; const queueMessage = this.notificationQueue[i];
if (queueMessage.tabId !== tab.id || queueMessage.type !== 'addLogin') { if (queueMessage.tabId !== tab.id || queueMessage.type !== 'addLogin') {
@@ -366,7 +366,7 @@ export default class NotificationBackground {
} }
} }
private async getDataForTab(tab: any, responseCommand: string) { private async getDataForTab(tab: chrome.tabs.Tab, responseCommand: string) {
const responseData: any = {}; const responseData: any = {};
if (responseCommand === 'notificationBarGetFoldersList') { if (responseCommand === 'notificationBarGetFoldersList') {
responseData.folders = await this.folderService.getAllDecrypted(); responseData.folders = await this.folderService.getAllDecrypted();

4
src/browser/browserApi.ts
View File

@@ -48,7 +48,7 @@ export class BrowserApi {
return null; return null;
} }
static tabSendMessageData(tab: any, command: string, data: any = null): Promise<any[]> { static tabSendMessageData(tab: chrome.tabs.Tab, command: string, data: any = null): Promise<any[]> {
const obj: any = { const obj: any = {
command: command, command: command,
}; };
@@ -60,7 +60,7 @@ export class BrowserApi {
return BrowserApi.tabSendMessage(tab, obj); return BrowserApi.tabSendMessage(tab, obj);
} }
static async tabSendMessage(tab: any, obj: any, options: any = null): Promise<any> { static async tabSendMessage(tab: chrome.tabs.Tab, obj: any, options: chrome.tabs.MessageSendOptions = null): Promise<any> {
if (!tab || !tab.id) { if (!tab || !tab.id) {
return; return;
} }