bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-03-01 02:51:24 +00:00
Code Issues Releases Wiki Activity

WIP Daniel

Browse Source 
Wiring up services (AchievementHub, HubAchievementService, AchievementNotifierService
This commit is contained in:
Daniel James Smith
2025-03-20 21:51:05 +01:00
parent 112f3e416a
commit d1e3c3c14f
8 changed files with 128 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
libs/angular/src/tools/achievements/achievement-notifier.service.ts
View File

@@ -32,9 +32,30 @@ export class AchievementNotifierService implements AchievementNotifierServiceAbs
* Invoke showing toast
*/
// FIXME getClientType browswer and achievementEarned.service.name.extension won't match
const account = await firstValueFrom(this.accountService.activeAccount$);
// const account = await firstValueFrom(this.accountService.activeAccount$);
// this.achievementService
// .achievementsEarned$(account.id)
// .pipe(
// // Removing filter for testing purposes
// // filter(achievementEarned => achievementEarned.service.name == this.platformUtilsService.getClientType())).pipe(
// switchMap((earned) => this.achievementService.achievementById$(earned.achievement.name)),
// tap((achievement) => {
// //eslint-disable-next-line no-console
// console.log(achievement);
// }),
// )
// .subscribe((achievement) => {
// this.toastService.showToast({
// variant: "info",
// title: achievement.name,
// message: achievement.description,
// icon: AchievementIcon,
// });
// });
// FIXME Migrate to use achievementHub.earned$() instead of achievementService.achievementsEarned$
this.achievementService
.achievementsEarned$(account.id)
.earned$
.pipe(
// Removing filter for testing purposes
// filter(achievementEarned => achievementEarned.service.name == this.platformUtilsService.getClientType())).pipe(
@@ -52,7 +73,5 @@ export class AchievementNotifierService implements AchievementNotifierServiceAbs
icon: AchievementIcon,
});
});
// FIXME Migrate to use achievementHub.earned$() instead of achievementService.achievementsEarned$
}
}