bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Implementing jest tests for AutofillInlineMenuIframeServce

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-11 08:31:58 -05:00
parent 17fa4f57f9
commit d3636eb96d
2 changed files with 41 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
apps/browser/src/autofill/overlay/inline-menu/iframe-content/autofill-inline-menu-iframe.service.spec.ts
View File

@@ -403,6 +403,27 @@ describe("AutofillInlineMenuIframeService", () => {
"*", "*",
); );
}); });
it("triggers a delayed closure of the inline menu", () => {
jest.useFakeTimers();
jest.spyOn(globalThis, "clearTimeout");
autofillInlineMenuIframeService["delayedCloseTimeout"] = setTimeout(jest.fn, 100);
sendPortMessage(portSpy, { command: "triggerDelayedAutofillInlineMenuClosure" });
expect(clearTimeout).toHaveBeenCalled();
expect(autofillInlineMenuIframeService["iframe"].style.opacity).toBe("0");
expect(autofillInlineMenuIframeService["iframe"].style.transition).toBe(
"opacity 65ms ease-out 0s",
);
jest.advanceTimersByTime(100);
expect(autofillInlineMenuIframeService["iframe"].style.transition).toBe(
"opacity 125ms ease-out 0s",
);
expect(sendExtensionMessageSpy).toHaveBeenCalledWith("closeAutofillInlineMenu", {
forceClose: true,
});
});
}); });
}); });

36
apps/browser/src/autofill/overlay/inline-menu/iframe-content/autofill-inline-menu-iframe.service.ts
View File

@@ -330,6 +330,26 @@ export class AutofillInlineMenuIframeService implements AutofillInlineMenuIframe
void this.sendExtensionMessage("closeAutofillInlineMenu", { forceClose: true }); void this.sendExtensionMessage("closeAutofillInlineMenu", { forceClose: true });
} }
/**
* Triggers a delayed closure of the inline menu to ensure that click events are
* caught if focus is programmatically redirected away from the inline menu.
*/
private handleDelayedAutofillInlineMenuClosure() {
if (this.delayedCloseTimeout) {
clearTimeout(this.delayedCloseTimeout);
}
this.updateElementStyles(this.iframe, {
transition: this.fadeOutOpacityTransition,
opacity: "0",
});
this.delayedCloseTimeout = globalThis.setTimeout(() => {
this.updateElementStyles(this.iframe, { transition: this.fadeInOpacityTransition });
this.forceCloseAutofillInlineMenu();
}, 100);
}
/** /**
* Handles mutations to the iframe element's attributes. This ensures that * Handles mutations to the iframe element's attributes. This ensures that
* the iframe element's attributes are not modified by a third party source. * the iframe element's attributes are not modified by a third party source.
@@ -407,20 +427,4 @@ export class AutofillInlineMenuIframeService implements AutofillInlineMenuIframe
return false; return false;
} }
private handleDelayedAutofillInlineMenuClosure() {
if (this.delayedCloseTimeout) {
clearTimeout(this.delayedCloseTimeout);
}
this.updateElementStyles(this.iframe, {
transition: this.fadeOutOpacityTransition,
opacity: "0",
});
this.delayedCloseTimeout = globalThis.setTimeout(() => {
this.updateElementStyles(this.iframe, { transition: this.fadeInOpacityTransition });
this.forceCloseAutofillInlineMenu();
}, 100);
}
} }