bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 17:23:37 +00:00
Code Issues Releases Wiki Activity

[AC-1347] Allow editing of collections in individual vault (#6081)

Browse Source 
* Rename Collection events to be more explicit

* Implement edit collection for individual vault row

* Implement edit and delete collection from individual vault header

* Implement bulk delete for collections in individual vault

* Clean up CollectionDialogResult properties

* Centralize canEdit and canDelete logic to Collection models

* Check orgId in canEdit and canDelete and add clarifying comments

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
This commit is contained in:
Robyn MacCallum
2023-10-04 17:15:20 -04:00
committed by GitHub
parent f43c3220dc
commit d40f996e71
17 changed files with 302 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/web/src/app/vault/components/collection-dialog/collection-dialog.component.ts
View File

@@ -51,7 +51,7 @@ export interface CollectionDialogParams {
export interface CollectionDialogResult {
action: CollectionDialogAction;
collection: CollectionResponse;
collection: CollectionResponse | CollectionView;
}
export enum CollectionDialogAction {
@@ -263,7 +263,7 @@ export class CollectionDialogComponent implements OnInit, OnDestroy {
this.i18nService.t("deletedCollectionId", this.collection?.name)
);
this.close(CollectionDialogAction.Deleted);
this.close(CollectionDialogAction.Deleted, this.collection);
};
ngOnDestroy(): void {
@@ -271,7 +271,7 @@ export class CollectionDialogComponent implements OnInit, OnDestroy {
this.destroy$.complete();
}
private close(action: CollectionDialogAction, collection?: CollectionResponse) {
private close(action: CollectionDialogAction, collection?: CollectionResponse | CollectionView) {
this.dialogRef.close({ action, collection } as CollectionDialogResult);
}
}