bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 06:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-14653] PM/AC Delete Cipher (#11996)

Browse Source 
* check for admin console for unassigned ciphers

* use `isUnassigned` helper

* remove unneeded comment
This commit is contained in:
Nick Krantz
2024-11-14 14:22:17 -06:00
committed by GitHub
parent b0c5b5e9e6
commit d4a381e1bd
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/web/src/app/vault/components/vault-item-dialog/vault-item-dialog.component.ts
View File

@@ -466,12 +466,11 @@ export class VaultItemDialogComponent implements OnInit, OnDestroy {
* Helper method to delete cipher. * Helper method to delete cipher.
*/ */
private async deleteCipher(): Promise<void> { private async deleteCipher(): Promise<void> {
const cipherIsUnassigned = const cipherIsUnassigned = this.cipher.isUnassigned;
!this.cipher.collectionIds || this.cipher.collectionIds?.length === 0;
// Delete the cipher as an admin when: // Delete the cipher as an admin when:
// - the organization allows for owners/admins to manage all collections/items // - The organization allows for owners/admins to manage all collections/items
// - the cipher is unassigned // - The cipher is unassigned
const asAdmin = this.organization?.canEditAllCiphers || cipherIsUnassigned; const asAdmin = this.organization?.canEditAllCiphers || cipherIsUnassigned;
if (this.cipher.isDeleted) { if (this.cipher.isDeleted) {